Date: Thu, 5 Nov 1998 11:48:18 -0800 (PST) From: "Dag-Erling C. Sm\xf8rgrav" <des@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: cvs commit: src/lib/libfetch common.c common.h Makefile README fetch.3 fetch.c fetch.h ftp.c http.c Message-ID: <199811051948.LAA08263@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
des 1998/11/05 11:48:17 PST
Modified files:
lib/libfetch Makefile README fetch.3 fetch.c fetch.h
ftp.c http.c
Added files:
lib/libfetch common.c common.h
Log:
First of a series of cleanups to libfetch. Changed files, in
alphabetical order:
Makefile:
Add common.c to SRCS.
Make debugging easier by making 'CFLAGS += -DNDEBUG' conditional on DEBUG
Don't declare struct {ftp,http}err in {ftp,http}err.c; use struct fetcherr
instead.
README:
Remove the todo list, which is out of date anyway.
common.c: (new file)
Gather utility functions in this file.
Merge the error reporting functions intp _fetch_errstring(),
_fetch_seterr() and _fetch_syserr().
Set fetchLastErrCode and fetchLastErrText appropriately when fetchConnect
fails.
common.h: (new file)
Gather internal prototypes and structures in this files.
fetch.3:
Undocument fetchFreeURL().
Document a few more known bugs.
Document fetchLastErrCode and fetchLastErrText.
fetch.c:
Add descriptive comments to all functions that lacked them.
Move fetchConnect() to common.c.
Obviate the need for fetchFreeURL(), and remove it.
fetch.h:
Modify struct url_t so the document part is at the end.
ftp.c:
Remove code that is duplicated elsewhere.
http.c:
Remove code that is duplicated elsewhere.
Prompted by: jkh
Revision Changes Path
1.6 +13 -13 src/lib/libfetch/Makefile
1.3 +3 -14 src/lib/libfetch/README
1.3 +26 -11 src/lib/libfetch/fetch.3
1.5 +28 -57 src/lib/libfetch/fetch.c
1.5 +3 -3 src/lib/libfetch/fetch.h
1.6 +7 -40 src/lib/libfetch/ftp.c
1.6 +2 -15 src/lib/libfetch/http.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199811051948.LAA08263>