Date: Thu, 23 Jul 2009 15:16:04 -0400 From: John Baldwin <jhb@freebsd.org> To: Bruce Simpson <bms@incunabulum.net> Cc: svn-src-stable-7@freebsd.org, Brian Somers <brian@freebsd.org>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce M Simpson <bms@freebsd.org> Subject: Re: svn commit: r195829 - stable/7/sys/dev/usb Message-ID: <200907231516.05011.jhb@freebsd.org> In-Reply-To: <4A68B40A.8020307@incunabulum.net> References: <200907230135.n6N1ZEar057595@svn.freebsd.org> <200907231023.47428.jhb@freebsd.org> <4A68B40A.8020307@incunabulum.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 23 July 2009 3:03:38 pm Bruce Simpson wrote: > John Baldwin wrote: > > ... > > That's because you merged to the file rather than to sys/. There's a set of > > instructions about mergning with SVN on the wiki that explains why to do > > kernel merges to sys/ instead of individual files. > > > > I read them, having been pointed at them by kib@ -- but they didn't > explain why contrib/pf was being touched at all. True enough, though I was pointing to the docs to explain merging to sys/ rather than the file. I should probably add some note to the wiki page about the "spurious" mergeinfo. The short version is that stable/7/sys/contrib/pf has two sets of mergeinfo: 1 from head/sys/contrib/pf and 2 from vendor-sys/pf. 2) is inherited from head and is a result of a vendor update of pf being merged over from the vendor area into sys/contrib/pf. It is not suitable for other parts of the kernel. 1) is the normal mergeinfo for merges from head/sys to stable/7/sys. However, a design choice in mergeinfo is that mergeinfo is not inherited via pathnames. Specifically, when the svn client starts walking up the path tree to find mergeinfo, it stops at the first parent directory that has any mergeinfo whatsoever and expects that mergeinfo to fully describe all the mergeinfo for its subtree. Thus, because the mergeinfo from 2) is present on sys/contrib/pf, the mergeinfo in 1) has to be duplicated in sys/contrib/pf in addition to sys. I'm not sure this is the best design, but that is the way Subversion works. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907231516.05011.jhb>