Date: Wed, 5 Jan 2000 08:31:28 -0800 (PST) From: Peter Wemm <peter@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/isa fd.c fdc.h Message-ID: <200001051631.IAA05609@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
peter 2000/01/05 08:31:28 PST
Modified files:
sys/isa fd.c fdc.h
Log:
Patch up some of the evilness left over from the early newbus porting.
In particular:
- Don't leave resources allocated in the probe routine. Allocate them
during probe and release them. Probe's job is to identify devices only.
- Don't abuse the ivars pointer.. (!). Create real ivars and use the
proper access system. (the bus_read_ivar method)
- Don't add the children until attach() has successfully grabbed the
hardware, otherwise there are potential leaks if attach fails.
Revision Changes Path
1.173 +135 -84 src/sys/isa/fd.c
1.17 +21 -1 src/sys/isa/fdc.h
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001051631.IAA05609>