Date: Fri, 8 Jul 2022 08:58:28 +0200 From: Sebastian Huber <sebastian.huber@embedded-brains.de> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: [PATCH 0/6] Simplify pps_capture() and pps_event() Message-ID: <5efeedf3-51dc-e186-48a4-c3dd14b7712e@embedded-brains.de> In-Reply-To: <CANCZdfru6K7Z-TCvRk3YcSGrU6EWSD8Ottd6vDNhe_2jQEFsrg@mail.gmail.com> References: <20220707152506.55626-1-sebastian.huber@embedded-brains.de> <CANCZdfru6K7Z-TCvRk3YcSGrU6EWSD8Ottd6vDNhe_2jQEFsrg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07.07.22 17:52, Warner Losh wrote: > You might have better luck getting these patches reviewed with either a > pull request against github > mentioning the usual time people (phk, etc), or as a series of > phabricator reviews adding said people. > If unsure, mention/add me and I'll add others :). Thanks for the hint. I opened a Github pull request: https://github.com/freebsd/freebsd-src/pull/604 > > Hackers is (or has been) a high enough volume list that this may not be > noticed by those people, > especially since there's not a strong tradition of reviewing patches here. > > On their surface (without having had time to study them in depth), these > seem reasonable improvements. > But having some context about why you are making these, and/or > measurements you've done to show no > harm (or hopefully an improvement) would be even better. This is > slightly tricky code that has had about 20 > years of "soak time" in some fairly demanding environments, and so some > caution is advised in updating > it. I don't use FreeBSD directly. I use the FreeBSD timecounters in RTEMS. We recently enabled the PPS_SYNC support and would like to use it for the time synchronization on a spacecraft. For this we have to do a specification and validation tests. This work increases with every "if" in the code. I didn't test the patch on a real system so far (in fact, patch 6 has a typo which was detected by the CI runner). We will definitely do extensive testing when the hardware is available. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5efeedf3-51dc-e186-48a4-c3dd14b7712e>