Date: Sun, 20 Apr 2003 13:32:11 +0200 From: "Simon L. Nielsen" <simon@nitro.dk> To: Hiroki Sato <hrs@eos.ocn.ne.jp> Cc: doc@FreeBSD.org Subject: Re: suggestion for adding a l10n-capable doc-format navi Message-ID: <20030420113210.GA390@nitro.dk> In-Reply-To: <20030420.195205.50333554.hrs@eos.ocn.ne.jp> References: <200304191540.h3JFeSxV052609@bmah.dyndns.org> <20030420.020436.102903006.hrs@eos.ocn.ne.jp> <200304191749.h3JHndxV053505@bmah.dyndns.org> <20030420.195205.50333554.hrs@eos.ocn.ne.jp>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2003.04.20 19:52:05 +0900, Hiroki Sato wrote: > How about the following: > > 1) WITH_FOO is defined and WITH_FOO!=NO, it means YES. > 2) WITH_FOO is defined and WITH_FOO==NO, it means NO. > 3) WITH_FOO is not defined, it means NO. Personally I think this is a bad idea since most other places in the FreeBSD makefiles it is only important if the variabel is set or not. > A problem of that defining of WITH_FOO always means YES is that > we cannot disable it if it is enabled by default in Makefile > using WITH_FOO?=YES. But as you pointed out, in other places > this sort of variables that is defined mean YES regardless of what > the value was. The above behavior is not against the old one, I think. The way the disabled case is handled some other places is by using a NO_FOO or NOFOO variable which then takes precedents over the WITH_FOO variable e.g. by : .if defined(NO_FOO) .undef WITH_FOO .endif I know this seems more troublesome but IMHO it is preferable since it is more consitent with all the other FreeBSD makefiles. I think it would be more intuitive if setting a make variable to NO really disabled the variable in all the FreeBSD makefiles but since it doesn't I think it is more or less impossible to remember when using NO is ok and when it is not. I know this seems like a bike shed (and probably is a bit) but I think consitency is rather important. -- Simon L. Nielsen [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+ooU68kocFXgPTRwRAuSAAJsFtFPfT8xDOZWIhEI0xBluMlbTJACgu3OJ z3V0QuE7qPD9L91BjzJX1lo= =cULz -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030420113210.GA390>