Date: Mon, 14 Apr 2008 21:15:44 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Randall Stewart <rrs@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c src/sys/sys protosw.h socket.h Message-ID: <20080414210941.U72408@fledge.watson.org> In-Reply-To: <200804141806.m3EI64St043794@repoman.freebsd.org> References: <200804141806.m3EI64St043794@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Apr 2008, Randall Stewart wrote:
> Add pru_flush routine so a transport can
> flush itself during Shutdown
>
> MFC after: 1 week
I'm not sure this is an MFCable change because:
(a) The new function pointer is inserted in the middle of the data protosw
data structure, changing the interpretation of existing compiled protosw
structures.
(b) Even if they were at the end of the structure, existing compiled protocols
might well have garbage (or un-related data) beyond the end of the data
structure, leading to a non-NULL pointer that is not a pointer to a flush
function.
Robert N M Watson
Computer Laboratory
University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080414210941.U72408>