Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 02 Sep 2015 10:12:15 -0400
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r287394 - head/etc
Message-ID:  <1441203135.5667.25.camel@hardenedbsd.org>
In-Reply-To: <201509021246.t82Ckhkn099532@repo.freebsd.org>
References:  <201509021246.t82Ckhkn099532@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--=-SoH8rS3hwyGJkhKisPoU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Gleb,

On Wed, 2015-09-02 at 12:46 +0000, Gleb Smirnoff wrote:
> Author: glebius
> Date: Wed Sep  2 12:46:42 2015
> New Revision: 287394
> URL: https://svnweb.freebsd.org/changeset/base/287394
>=20
> Log:
>   Fix dynamic attach/detach of 802.11 devices after r287197:
>  =20
>   o In pccard_ether add code to start children of a 802.11
>     device, that are configured in rc.conf.
>   o In devd.conf provide a regex matching all 802.11 devices,
>     and on match run pccard_ether to spawn children.
>  =20
>   PR:		202784
>   Submitted by:	<vidwer gmail.com>
>   In collaboration with:	"Oleg V. Nauman" <oleg opentransfer.com>
>=20
> Modified:
>   head/etc/devd.conf
>   head/etc/pccard_ether
>=20
> Modified: head/etc/devd.conf
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/etc/devd.conf	Wed Sep  2 05:55:57 2015	(r287393)
> +++ head/etc/devd.conf	Wed Sep  2 12:46:42 2015	(r287394)
> @@ -22,6 +22,9 @@ options {
>  		"(aac|adv|adw|aha|ahb|ahc|ahd|aic|amd|amr|asr|bt|ciss|ct|dpt|\
>  		esp|ida|iir|ips|isp|mlx|mly|mpt|ncr|ncv|nsp|stg|sym|trm|wds)\
>  		[0-9]+";
> +	set wifi-driver-regex
> +		"(ath|bwi|bwn|ipw|iwi|iwn|malo|mwl|ral|rsu|rum|run|uath|upgt|\
> +		ural|urtw|urtwn|wi|wpi|wtap|zyd)[0-9]+";
>  };

Should the new iwm driver also be added?

> =20
>  # Note that the attach/detach with the highest value wins, so that one c=
an
> @@ -57,17 +60,16 @@ notify 0 {
>  };
> =20
>  #
> -# Like Ethernet devices, but separate because
> -# they have a different media type.  We may want
> -# to exploit this later.
> +# Like Ethernet devices, but separate because 802.11 require spawning
> +# wlan(4) interface.
>  #
> -detach 0 {
> -	media-type "802.11";
> -	action "/etc/pccard_ether $device-name stop";
> -};
>  attach 0 {
> -	media-type "802.11";
> -	action "/etc/pccard_ether $device-name start";
> +	device-name "$wifi-driver-regex";
> +	action "/etc/pccard_ether $device-name startchildren";
> +};
> +detach 0 {
> +	device-name "$wifi-driver-regex";
> +	action "/etc/pccard_ether $device-name stopchildren";
>  };
>  notify 0 {
>  	match "system"		"IFNET";
>=20
> Modified: head/etc/pccard_ether
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/etc/pccard_ether	Wed Sep  2 05:55:57 2015	(r287393)
> +++ head/etc/pccard_ether	Wed Sep  2 12:46:42 2015	(r287394)
> @@ -17,6 +17,9 @@ stop_precmd=3D"checkauto"
>  stop_cmd=3D"pccard_ether_stop"
>  restart_precmd=3D"checkauto"
>  restart_cmd=3D"pccard_ether_restart"
> +startchildren_cmd=3D"pccard_ether_startchildren"
> +stopchildren_cmd=3D"pccard_ether_stopchildren"
> +extra_commands=3D"startchildren stopchildren"
> =20
>  setup_routes()
>  {
> @@ -114,6 +117,20 @@ pccard_ether_restart()
>  	pccard_ether_start
>  }
> =20
> +pccard_ether_startchildren()
> +{
> +	for child in `get_if_var $ifn wlans_IF`; do
> +		/etc/rc.d/netif quietstart $child
> +	done
> +}
> +
> +pccard_ether_stopchildren()
> +{
> +	for child in `get_if_var $ifn wlans_IF`; do
> +		/etc/rc.d/netif quietstop $child
> +	done
> +}
> +
>  ifn=3D$1
>  shift
>  if [ -z "$*" ]; then
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

--=20
Shawn Webb
HardenedBSD

GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE

--=-SoH8rS3hwyGJkhKisPoU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCgAGBQJV5wO/AAoJEGqEZY9SRW7uWV8P/A5g4o2fIOcZqZMTpQlp8s7V
jdGIjLvW+RwB8QeKi7t5c4L7wwlVQiVTV0n70xRA4EVcUeAQMTVPogU9vQPMLhkP
ixmTmDZNPK2XWFN/HNFQbN1rke27l9ddEKMAL3QOUD9J/hZg+htUSn4ceMVeJDj1
Kl7Zehu9EIuoxaUIPCWw3gGsnX9tSRILgpGJBHBERLR36wSs9SkrP12/vb6iI/3Q
667W0WnMnIGW+NlHxsNS4kjJJ33kzgvPWI4pK/k6nofEyGLmAH+9II3Z+gLYHmbr
44yeUeDx1BlIq/UuRM3tyZLiZ/XP3xBnfynPb5rAyCaPrRim3giAPo6/Bfp/PXX0
885WcZRzdkz117dLXgBCjFIOOm9oh26yC7KFrvCgAJcJeimxlP91rg9q6wwRBsuI
680NhSHVMIWaMLVpVuWO5zyqN8hCxfQ8c9B1K3nxzUKbhTWqjmQ2MCAhhOfKcnh6
O5MskntG6fhc2/EGDMFU4iJGbZpaU/3Ft+Fk2OVYR15Hh82TRLxP8IMitEr2BRfe
rTR4+PoydlyRt5vbP0tAcBi8oV8ZyQAzYqwfJAgWpAEQekFUW6focIm2rU5W9lo9
ID1WWbY4l9queGf537rLgQm33kil2dq2xQ2JtT09YRUGvdxrBtFHyF3vMOYuoDq1
NJ60SpHkjCqGp8fh1gU/
=tPj/
-----END PGP SIGNATURE-----

--=-SoH8rS3hwyGJkhKisPoU--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1441203135.5667.25.camel>