Date: Mon, 19 Mar 2012 11:41:34 -0400 From: Eitan Adler <eadler@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd Message-ID: <CAF6rxgk1zfS8hDQPmFWEYZEFehvxyjUSZhbH-WXMLn3rLc754w@mail.gmail.com> In-Reply-To: <201203190835.27561.jhb@freebsd.org> References: <201203190041.q2J0femX042684@svn.freebsd.org> <201203190835.27561.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 19, 2012 at 8:35 AM, John Baldwin <jhb@freebsd.org> wrote: > On Sunday, March 18, 2012 8:41:40 pm Eitan Adler wrote: >> Author: eadler >> Date: Mon Mar 19 00:41:40 2012 >> New Revision: 233136 >> URL: http://svn.freebsd.org/changeset/base/233136 >> >> Log: >> X11BASE is not used any more and has been killed by the x11 team. >> >> Reviewed by: ??? >> Approved by: ??? >> MFC after: 3 days >> >> Modified: >> head/secure/usr.bin/ssh/Makefile >> head/secure/usr.sbin/sshd/Makefile > > This looks wrong. While X11BASE is certainly dead, LOCALBASE is not, so the > existing code should have been changed, but not removed. Something like this: > > .if defined(LOCALBASE) > CFLAGS+= -DXAUTH_PATH=\"${LOCALBASE}/bin/xauth\" > .endif I think I missed "X11BASE?=${LOCALBASE}" in the original code making me believe this change was a no-op. I'll have a patch to fix this soon. -- Eitan Adler Source & Ports committer X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgk1zfS8hDQPmFWEYZEFehvxyjUSZhbH-WXMLn3rLc754w>