Date: Tue, 3 Jan 2006 12:21:56 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andrew Thompson <thompsa@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_bridge.c Message-ID: <20060103112156.GB8302@garage.freebsd.pl> In-Reply-To: <200601022302.k02N2hBV014825@repoman.freebsd.org> References: <200601022302.k02N2hBV014825@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jan 02, 2006 at 11:02:43PM +0000, Andrew Thompson wrote: +> thompsa 2006-01-02 23:02:43 UTC +> +> FreeBSD src repository +> +> Modified files: +> sys/net if_bridge.c +> Log: +> Fix a brain-o in the last commit, the conditional was always false. [...] +> - if (flags & IFBAF_DYNAMIC) +> + if ((flags & IFBAF_TYPEMASK) == IFBAF_DYNAMIC) On first look, I thought it does exactly the same thing, but I checked the code and now I know it doesn't - IFBAF_DYNAMIC is 0x00. Another example that giving 0 for a define which should represent a flag is a bad idea. The same problem we had in the past with M_NOWAIT. You should consider changing it to some real value to avoid mistakes like this in the future or removing IFBAF_DYNAMIC entirely and changing such condition to 'if (!(flags & IFBAF_STATIC))'. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDul5UForvXbEpPzQRAkJ2AJ9xak+x91DOBma4Hewi5Z2db1kqQgCfXfY4 2k7AdYRFxrOTWm8gvTkXLuY= =BPPP -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060103112156.GB8302>