Date: Tue, 24 May 2011 18:10:11 GMT From: Chris Rees <utisoft@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large number of jails quickly Message-ID: <201105241810.p4OIABBv094429@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/148777; it has been noted by GNATS.
From: Chris Rees <utisoft@gmail.com>
To: joeb@a1poweruser.com
Cc: bug-followup@freebsd.org, joeb1@a1poweruser.com
Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large
number of jails quickly
Date: Tue, 24 May 2011 19:02:53 +0100
On 24 May 2011 17:48, <joeb@a1poweruser.com> wrote:
> From: =A0 =A0 Chris Rees <utisoft@gmail.com>
CMR> Hi Joe,
CMR>
CMR> I understand your frustration at the port taking a while to be
CMR> committed, but you simply can't expect things to be committed when
CMR> advice is ignored.
CMR>
CMR> Why are you still using ${CP} when you should be using
CMR> ${INSTALL_DATA}, and ${CP} -r when you should be using
CMR> ${COPYTREE_SHARE}?
CMR>
CMR> Why is the DISTFILES line commented rather than removed?
CMR>
CMR> Why aren't you handling configuration files properly [1]?
CMR>
CMR> Why have you included the WRKDIR in the shar?
CMR>
CMR> Why have you _still_ not run portlint?
CMR>
CMR> Also, your mailer is messing up the shar. You're better off putting it
CMR> up on a site somewhere, I'll be happy to host a correct shar for you
CMR> if you email it to me as a tar.
>
>
>
>
> ################################################################
>
> I dont know how you came to write the above.
> If you read the last shar post to ports/148777 you will see that all thos=
e
> items have been corrected.
Hands up, I'm sorry, you have corrected _two_ (not all) of the issues
-- the WRKDIR in shar issue.
You still haven't run portlint, aren't handling config files properly,
nor have you used the correct method of installing a tree of files.
I've fixed these issues for you, please approve [1].
Also, please fix your mailer to not use quoted-printable -- it upsets
GNATS and means I have to cartwheel with sed and tr on your patches.
Chris
[1] http://www.bayofrum.net/~crees/patches/qjail.shar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105241810.p4OIABBv094429>