Date: Mon, 22 Apr 2013 13:40:13 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Joe Holden <joe@rewt.org.uk>, "freebsd-mips@FreeBSD.org" <freebsd-mips@freebsd.org> Subject: Re: kern/177876: [mips] kernel stack overflow panic on mips64, EdgeRouter Lite Message-ID: <CACVs6=9kisUi0S3jS6NnXmwUEPg2pC%2Bz-%2BMdRVGtjkJnKEq70A@mail.gmail.com> In-Reply-To: <FD6F892F-B86A-43E1-9D43-DEF3EE733A4C@bsdimp.com> References: <201304220300.r3M301iY093070@freefall.freebsd.org> <CAJ-Vmok7m9%2B3sky1swEP6ZTnZNLpkmwTC2tOqzGNaSFwY7WmFA@mail.gmail.com> <51753506.3070901@rewt.org.uk> <CAJ-VmomKi%2BpmZ6GAjds-=RXRET=aW65dsmxe3H4m%2BfdbxoecGw@mail.gmail.com> <CACVs6=8XdAgccufabeoXEXCFGGVZ_EWJ8c-KdRz4xr9SvBxrrw@mail.gmail.com> <EBE52100-4C0F-4B61-B872-CA30B99E2940@bsdimp.com> <CACVs6=8Hv5uF0zV=3%2BkZ=zsObSfQjiSY4t3op1EBytrunJdCGg@mail.gmail.com> <FD6F892F-B86A-43E1-9D43-DEF3EE733A4C@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 22, 2013 at 1:35 PM, Warner Losh <imp@bsdimp.com> wrote: > > On Apr 22, 2013, at 2:29 PM, Juli Mallett wrote: > >> On Mon, Apr 22, 2013 at 1:27 PM, Warner Losh <imp@bsdimp.com> wrote: >>> It sure looks like you are right... I have a full new tree building just to make sure... :( >>> >>> Then again, it would be useful to document where these dependencies lie to help prevent others from tripping over this in the future :( >> >> We should use genassym to generate trapframe offsets instead of having >> hand-coded defines for these, perhaps? I haven't thought it through >> very fully, but that seems a lot better. > > I'll look into this next to ensure that they all match. Can you think of any other places? A quick grep shows nothing obvious... If the header gets nuked, we'll find out fast :) (And I really do think that's the right way forward...)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACVs6=9kisUi0S3jS6NnXmwUEPg2pC%2Bz-%2BMdRVGtjkJnKEq70A>