Date: Thu, 04 Sep 2008 17:29:50 +0300 From: Giorgos Keramidas <keramida@freebsd.org> To: Tim Kientzle <kientzle@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: cpio reporting too many 'blocks' Message-ID: <87ljy8j869.fsf@kobe.laptop> In-Reply-To: <48BF6D2C.4030001@freebsd.org> (Tim Kientzle's message of "Wed, 03 Sep 2008 22:07:56 -0700") References: <87hc8x74nd.fsf@kobe.laptop> <48BEB5E1.8080906@freebsd.org> <87ej41rkpk.fsf@kobe.laptop> <48BF6D2C.4030001@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 03 Sep 2008 22:07:56 -0700, Tim Kientzle <kientzle@freebsd.org> wrote:
>Giorgos Keramidas wrote:
>> ACK. If you want me to run any tests or test patches, please feel free
>> to send them this way :-)
>
> I think I found it. <sigh> Try this and let me know.
>
> Tim
> Index: cpio.c
> ===================================================================
> --- cpio.c (revision 182102)
> +++ cpio.c (working copy)
> @@ -863,7 +863,6 @@
> r = archive_write_close(cpio->archive);
> if (r != ARCHIVE_OK)
> cpio_errc(1, 0, archive_error_string(cpio->archive));
> - archive_write_finish(cpio->archive);
>
> if (!cpio->quiet) {
> blocks = (archive_position_uncompressed(cpio->archive) + 511)
> @@ -872,6 +871,7 @@
> blocks == 1 ? "block" : "blocks");
> }
>
> + archive_write_finish(cpio->archive);
> }
That's it. Not the blocks reported look more sensible:
keramida@kobe:/ws/bsd/doc$ find * | cpio -p -dmu /hg/doc/bsd-import
40345 blocks
keramida@kobe:/ws/bsd/doc$ echo $(( $( find * | xargs cat | wc -c ) / 512 ))
40916
Thanks :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87ljy8j869.fsf>