Date: Tue, 14 Jun 2005 01:14:40 +0000 (UTC) From: Jeff Roberson <jeff@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern vfs_syscalls.c vfs_vnops.c Message-ID: <200506140114.j5E1Efri041232@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jeff 2005-06-14 01:14:40 UTC
FreeBSD src repository
Modified files:
sys/kern vfs_syscalls.c vfs_vnops.c
Log:
- Remove vnode lock asserts at the end of vfs syscalls. These asserts were
used to ensure that we weren't exiting the syscall with a lock still
held. This wasn't safe, however, because we'd already executed a vput()
and on a loaded system the vnode may have been free'd by the time we
assert. This functionality is also handled by the td_locks assert in
userret, which doesn't tell you what the syscall was, but will at least
panic before you deadlock.
Sponsored by: Isilon Systems, Inc.
Discovred by: Peter Holm
Approved by: re (blanket vfs)
Revision Changes Path
1.391 +0 -18 src/sys/kern/vfs_syscalls.c
1.233 +0 -2 src/sys/kern/vfs_vnops.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506140114.j5E1Efri041232>