Date: Mon, 02 Feb 2026 13:31:24 +0000 From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: ff9fe85ff245 - main - nvmecontrol: telemetry-log don't sanity check host generation number Message-ID: <6980a72c.31385.4fe39fee@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=ff9fe85ff245bfbf6f54f98175282be5cf500cb3 commit ff9fe85ff245bfbf6f54f98175282be5cf500cb3 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2026-02-02 13:30:22 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2026-02-02 13:31:21 +0000 nvmecontrol: telemetry-log don't sanity check host generation number Don't sanity check the host initiated generation number. It's not necessarily constant between the two log page fetches. nvme-cli doesn't do this stanity check and it generates a lot of false positives. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D55018 --- sbin/nvmecontrol/telemetry.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sbin/nvmecontrol/telemetry.c b/sbin/nvmecontrol/telemetry.c index bfa1325974d5..c22d53ecdfed 100644 --- a/sbin/nvmecontrol/telemetry.c +++ b/sbin/nvmecontrol/telemetry.c @@ -160,16 +160,6 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) chunk = size; read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, off, 0, 0, 0, &buf, chunk); - if (off == 0) { - /* - * Sanity check to make sure that the generation number - * didn't change between the two reads. - */ - if (tlp.hi_gen != buf.hi_gen) - warnx( - "Generation number changed from %d to %d", - tlp.hi_gen, buf.hi_gen); - } if (write(fdout, &buf, chunk) != chunk) err(EX_IOERR, "Error writing %s", opt.outfn); off += chunk;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6980a72c.31385.4fe39fee>