Date: Thu, 30 Mar 2006 19:17:07 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netipsec xform.h xform_ipip.c Message-ID: <20060330191338.Q2181@maildrop.int.zabbadoz.net> In-Reply-To: <200603301857.k2UIv46o066136@repoman.freebsd.org> References: <200603301857.k2UIv46o066136@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 30 Mar 2006, Bjoern A. Zeeb wrote: > bz 2006-03-30 18:57:04 UTC > > FreeBSD src repository > > Modified files: > sys/netipsec xform.h xform_ipip.c > Log: > Fix more stack corruptions on amd64. > > Vararg functions have a different calling convention than regular > functions on amd64. Casting a varag function to a regular one to > match the function pointer declaration will hide the varargs from > the caller and we will end up with an incorrectly setup stack. I will try to go over sys/net*/** or even sys/** somewhen the next days and see if I can find more of them. If anybody knows an easy way to find all casted function pointers that are using varargs let me know ;-) -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060330191338.Q2181>