Date: Wed, 9 Jun 2004 12:24:04 -0400 From: John Baldwin <jhb@FreeBSD.org> To: freebsd-arch@FreeBSD.org Cc: Poul-Henning Kamp <phk@phk.freebsd.dk> Subject: Re: dev_t / udev_t confusion ? Message-ID: <200406091224.04653.jhb@FreeBSD.org> In-Reply-To: <55790.1086796559@critter.freebsd.dk> References: <55790.1086796559@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 09 June 2004 11:55 am, Poul-Henning Kamp wrote: > In message <53993.1086779790@critter.freebsd.dk>, Poul-Henning Kamp writes: > >The change proposed is more or less to do: > > s/dev_t/struct cdev */ > > s/udev_t/dev_t/ > >over all the kernel sources (366 files or so). > > Looks like a "yea" so far, so I have a couple of follow-up questions: > > struct cdev currently has members named si_* because it > used to be called "specinfo", do we want to change that > inconsistency at the same time ? (either by reverting to > the specinfo name or by changing to a cd_ prefix ? Sure, maybe dev_foo prefix? cd_ is fine though, just pick one and be consistent. > cdevsw->ioctl() takes a caddr_t pointer argument which > really should be a void *, do we want to change that > as well (since it is all the same files we'll have to > change). Ok with me. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406091224.04653.jhb>