Date: Sun, 13 May 2001 18:40:03 -0700 (PDT) From: Cyrille Lefevre <clefevre-lists@noos.fr> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/27258: getty didn't check if if= isn't empty Message-ID: <200105140140.f4E1e3J14981@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/27258; it has been noted by GNATS. From: Cyrille Lefevre <clefevre-lists@noos.fr> To: Bruce Evans <bde@zeta.org.au> Cc: Cyrille Lefevre <clefevre@poboxes.com>, FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/27258: getty didn't check if if= isn't empty Date: 14 May 2001 03:36:16 +0200 Bruce Evans <bde@zeta.org.au> writes: [snip] > > - if (first_time && IF) { > > + if (first_time && IF && *IF) { > > int fd; > > > > if ((fd = open(IF, O_RDONLY)) != -1) { > > This is safer than `:if=/bin/sh:'. It just causes the open to fail > just like for any other nonexistent file (POSIX standard). yes, but this syscall isn't needed, so, why not to get rid of it if if= is empty ? Cyrille. -- home: mailto:clefevre@poboxes.com UNIX is user-friendly; it's just particular work: mailto:Cyrille.Lefevre@edf.fr about who it chooses to be friends with. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105140140.f4E1e3J14981>