Date: Tue, 03 Sep 2019 14:07:25 -0000 From: Cy Schubert <Cy.Schubert@cschubert.com> To: rgrimes@freebsd.org Cc: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346341 - head/tools/build Message-ID: <201904180332.x3I3WJTt096491@slippy.cwsent.com> In-Reply-To: Message from "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> of "Wed, 17 Apr 2019 18:07:26 -0700." <201904180107.x3I17QDc002945@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201904180107.x3I17QDc002945@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > > Author: cy > > Date: Thu Apr 18 01:02:00 2019 > > New Revision: 346341 > > URL: https://svnweb.freebsd.org/changeset/base/346341 > > > > Log: > > As an interim measure until a more permanent solution is implemented > > workaround the following error: > > > > /usr/src/contrib/elftoolchain/strings/strings.c:198:55: error: use of > > undeclared identifier > > 'FA_OPEN' fa = fileargs_init(argc, argv, O_RDONLY, 0, &rights, FA_OPEN); > > > > Reported by: O. Hartmann <ohartmann@walstatt.org> > > Reported by: Michael Butler <imb@protected-networks.net> > > Reported by: gjb@ & cy@ (implicit) > > Reviewed by: emaste@ > > Noted by: rgrimes@ > > > > Modified: > > head/tools/build/Makefile > > > > Modified: head/tools/build/Makefile > > =========================================================================== > === > > --- head/tools/build/Makefile Thu Apr 18 00:38:54 2019 (r34634 > 0) > > +++ head/tools/build/Makefile Thu Apr 18 01:02:00 2019 (r34634 > 1) > > @@ -59,9 +59,7 @@ INCS+= capsicum_helpers.h > > INCS+= libcasper.h > > .endif > > > > -.if !exists(/usr/include/casper/cap_fileargs.h) > > CASPERINC+= ${SRCTOP}/lib/libcasper/services/cap_fileargs/cap_filea > rgs.h > > -.endif > > As a further note, we should probably hunt for any thing > that is explicity looking at /usr/include/... in a Makefile, > as that is minimally missing a ${DESTDIR} argument. > > The above may of actually worked if it had been written: > .if !exists(${DESTDIR}/usr/include/casper/cap_fileargs.h) > someone may wish to test that. > > Also a pathname rooted at / without ${DESTDIR} is almost certainly a mistake. This is a better solution. I tested this in a tree with a duplicated environment: Problem solved. Before this is committed it should be tested on one of the universe machines. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904180332.x3I3WJTt096491>