Date: Wed, 29 May 2002 13:48:00 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: "David O'Brien" <obrien@FreeBSD.ORG> Cc: Julian Elischer <julian@elischer.org>, John Baldwin <jhb@FreeBSD.ORG>, FreeBSD current users <current@FreeBSD.ORG> Subject: Re: Seeking OK to commit KSE MIII Message-ID: <200205292048.g4TKm00R063103@apollo.backplane.com> References: <XFMail.20020529124710.jhb@FreeBSD.org> <Pine.BSF.4.21.0205291057020.12315-100000@InterJet.elischer.org> <20020529124434.A2156@dragon.nuxi.com> <200205292007.g4TK71YD062671@apollo.backplane.com> <20020529133747.B683@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:> Furthermore, it is an extreme and inappropriate imposition on Julian
:> to require that he extract all the alleged 'gratuitous braces and
:> ()'s)' into a separate commit.
:
:Uh, no it isn't. That is the rules we operate under. This type of
:request comes up _daily_, and is generally agreed upon by most
:committers. Sorry, but the work involved is just part of making commits.
I see the request come up a lot. Most of the requests and most of
the justification appears to come from people who are acting in
the role of net-police rather then for any reason actually related to
development work.
If you read the diffs separately in the midst of a review, then good
for you! You are an exception to the rule. I find it a waste of time
myself. I just diff the whole damn thing when I review the code so I
can see everything context and do a single pass over it. It takes
less time. Consider the amount of time Julian would have to waste to
locate, separate, and commit the pieces, verses the amount of time the
few (three?) developers likely to review his patches will waste going
through the crud. In your case that amount of time wasted will be near
0 since you say you are looking at the crud along with the meat.
Then consider which of the following actions is more appropriate:
* Hey J, please separate out the whitespace/braces changes and
make two separate commits before doing anything else.
* Hey J, the patches look good but I sure would appreciate it if,
the next time, you would get the whitespace/bracing changes
committed and out of the way first. Don't worry about it this
time.
In regards to developer relationships and keeping things civil and
less stressful on the lists, #(2) is the far better solution and,
frankly, I think we should *CODIFY* that in the rules certain people
seem to enjoy quoting so much.
And that, David, is why the whitespace rules should be a 'rules of thumb'
rather then a 'you will do this or else' rule.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205292048.g4TKm00R063103>