Date: Thu, 6 Jan 2005 21:59:50 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: freebsd-current@freebsd.org Subject: Re: human-readable swap partition sizes with pstat -sh Message-ID: <20050106195950.GA34916@gothmog.gr> In-Reply-To: <20050106195719.GB24896@odin.ac.hmc.edu> References: <20050106191201.GA30826@gothmog.gr> <20050106195719.GB24896@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2005-01-06 11:57, Brooks Davis <brooks@one-eyed-alien.net> wrote: > On Thu, Jan 06, 2005 at 09:12:01PM +0200, Giorgos Keramidas wrote: > > The following patch adds support for human-readable partition sizes in > > pstat -s and swapinfo output, when the -h option is used: > > > > gothmog:/d/src/usr.sbin/pstat$ ./pstat -s > > Device 1K-blocks Used Avail Capacity > > /dev/ad1s1b 5120000 12 5120000 0% > > > > gothmog:/d/src/usr.sbin/pstat$ ./pstat -sh > > Device 1K-blocks Used Avail Capacity > > /dev/ad1s1b 5120000 12K 4.9G 0% > > > > Does anyone have comments or suggestions for further improvement? > > Look good in general. Does -kh make sense? I think so since it would > force the blocks line, but I'm not 100% sure. It does. -k only affects the way 'number of blocks' is printed. The sizes of 'used' and 'avail' are calculated differently -- in bytes, otherwise humanize_number() would return bogus strings. > On minor, mostly style nit is that while intmax_t is 64-bits, nothing > requires that so you should probably have conver return an int64_t. I lost you a bit here. > I'd argue that we might want to replace the int64_t in humanize_number > with intmax_t since that wouldn't change the ABI (or API due to implicit > casts), but would mean we wouldn't have to add a humanize_number128 > later if some architecture grows 128-bit ints for some reason or > another. Indeed, that would be nice :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050106195950.GA34916>