Date: Wed, 10 Sep 2014 00:43:40 +0200 From: olli hauer <ohauer@gmx.de> To: apache@freebsd.org Cc: Mathieu Arnold <mat@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: apache 2.2 ports Message-ID: <540F829C.10301@gmx.de> In-Reply-To: <F83736752D4F0BB901E2A3DE@atuin.in.mat.cc> References: <8DF8037F-F9EC-488D-86C4-0923789C174C@adamw.org> <8c7c200293f6d84e756d6eec4a1edcc2@mail.feld.me> <1078D71E80C9283D7F23513F@ogg.in.absolight.net> <540F7CFB.4050304@gmx.de> <F83736752D4F0BB901E2A3DE@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-09-10 00:22, Mathieu Arnold wrote: > > > +--On 10 septembre 2014 00:19:39 +0200 olli hauer <ohauer@gmx.de> wrote: > | On 2014-09-08 15:51, Mathieu Arnold wrote: > |> > |> > |> +--On 8 septembre 2014 13:41:54 +0000 Mark Felder <feld@freebsd.org> > |> wrote: > |> | September 6 2014 10:24 AM, "Adam Weinberger" <adamw@adamw.org> wrote: > |> |> apache team - > |> |> > |> |> So it seems that setting USE_APACHE=22 doesn’t actually depend on > |> |> apache-2.2. This means that every USE_APACHE=22 port is broken, and as > |> |> of right now won’t have any 10.1 packages. > |> |> > |> |> I’m happy to go through and add "DEFAULT_VERSIONS= APACHE=22” to > |> |> this ports, but I wanted to check with you guys first. Is that the > |> |> right way to fix it? Is there something else that can be done to make > |> |> USE_APACHE=22 actually depend on apache-2.2? > |> |> > |> | > |> | FYI I had to solve this problem today with the following two make.conf > |> | options: > |> | > |> | DEFAULT_VERSIONS= apache=2.2 > |> | > |> | (note it's 2.2, not 22 -- bsd.default-versions.mk shows a period should > |> | be used) > |> | > |> | APACHE_PORT= www/apache22 > |> | > |> | > |> | Previously I only had the DEFAULT_VERSIONS entry and it worked fine. > |> | Suddenly I needed to add APACHE_PORT as well. This is with an up to > |> | date ports tree -- my packages build automatically every 8 hours. > |> > |> Yes, bapt sent a patch to fix that > |> <https://people.freebsd.org/~bapt/apache-version.diff>; > | > | > | Based on the patch from bapt, I finished a new one (some cases where > | missing) > | https://people.freebsd.org/~ohauer/diffs/apache/bsd.apache.mk_20140909.di > | ff > | > | Perhaps someone wants to test and/or review before I commit this fix > | tomorrow. > > Using our code review tool to post this patch would have been nice, easier > to comment on, and to look at, too :-) > > <https://wiki.freebsd.org/CodeReview>; Here you go: https://reviews.freebsd.org/D750 -- olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?540F829C.10301>