Date: Tue, 14 Jun 2011 23:52:46 -0400 From: jhell <jhell@DataIX.net> To: freebsd-rc@freebsd.org Subject: Re: [PATCH] Knock out two if statements, one eval & IDCMD with builtin test. Message-ID: <20110615035246.GB12185@DataIX.net> In-Reply-To: <20110615034526.GA12185@DataIX.net> References: <20110615034526.GA12185@DataIX.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This should have been without the ``false'' On Tue, Jun 14, 2011 at 11:45:26PM -0400, jhell wrote: > > After looking over Jilles patch on this same list it made ID & IDCMD > catch my eye when I seen the $(eval $IDCMD) where it was the only place > it was used throughout the whole system in which it calls another if > statement from IDCMD to check the presence of /usr/bin/id. > > This is not bad at all, don't get me wrong but this could be done from > one location to knock out the eval and two if statements with one > builtin test right from the ID variable itself and get rid of the need > for the IDCMD. > > Slight speed improvement ? maybe... cleaner yes. > > As for functionality can anyone think of a need to wait for processing > this till run_rc_command is thrown ? if so should it be escaped and > re-eval'd as $(eval \$ID) or something similiar later ? >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110615035246.GB12185>