Date: Thu, 18 Jan 2007 09:19:22 -0500 From: John Baldwin <jhb@freebsd.org> To: Roman Divacky <rdivacky@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 113097 for review Message-ID: <200701180919.22897.jhb@freebsd.org> In-Reply-To: <200701180930.l0I9UAlw024022@repoman.freebsd.org> References: <200701180930.l0I9UAlw024022@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 18 January 2007 04:30, Roman Divacky wrote: > http://perforce.freebsd.org/chv.cgi?CH=113097 > > Change 113097 by rdivacky@rdivacky_witten on 2007/01/18 09:29:19 > > In linux_fork and linux_vfork create the process in stopped state > to be sure that the new process runs with fully initialized emuldata > structure [1]. Also fix the vfork (both in linux_clone and linux_vfork) > race that could result in never woken up process [2]. > > Reported by: Scot Hetzel [1] > Suggested by: jhb [2] One minor nit would be to fix the comments that say '/* make it run */' to be a full sentence (style(9)). You can use the comment from linux_clone() for that if you want. The code changes look good though. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701180919.22897.jhb>