Date: Mon, 15 Oct 2012 18:07:19 -0700 From: Xin Li <delphij@delphij.net> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, Maxim Sobolev <sobomax@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r241576 - in head/usr.sbin/cron: cron crontab lib Message-ID: <507CB347.3040502@delphij.net> In-Reply-To: <CAF6rxg=kkaNjgU=JKKqR%2Bh7-VXBC6GtvGDXm3c58%2B_UbtTvG9w@mail.gmail.com> References: <201210150821.q9F8Lobc047576@svn.freebsd.org> <CAJ-VmomRx_n6LoXeQCPAX-KzVYqPcjhZt1J0MX89FiEEojPePw@mail.gmail.com> <CAF6rxgn9DcwqnZW4uwS8OLmKMbs3Fg9x8o50KWzDunLS_H-tDA@mail.gmail.com> <CAJ-VmomTAPAOGjdJ8UZyY=mfnhbMAexyr_Fz9DMNqiyzDV0_fQ@mail.gmail.com> <CAF6rxg=kkaNjgU=JKKqR%2Bh7-VXBC6GtvGDXm3c58%2B_UbtTvG9w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/15/12 17:23, Eitan Adler wrote: > On 15 October 2012 19:26, Adrian Chadd <adrian@freebsd.org> wrote: >> On 15 October 2012 16:10, Eitan Adler <eadler@freebsd.org> >> wrote: >>> On 15 October 2012 18:45, Adrian Chadd <adrian@freebsd.org> >>> wrote: >>>> Why not sleep for the amonut of time needed before the next >>>> event? >>> >>> If the crontab changes in the meantime. If the next event is in >>> a week, but you modify the crontab, you don't want to sleep >>> until next event. >> >> Right. So "check the crontab file" event is also an event with a >> timestamp in the future. >> >> Maybe crontab should be using a command via a socket to reload, >> rather than stat'ing files.. > > "Why we stat the file every quantum instead of using kqueue is a > different question." Because it's not guaranteed to work on every filesystems? But yes I think it would be a good idea to implement it and use it when all filesystems used to store crontabs supports it. Cheers, - -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJQfLNHAAoJEG80Jeu8UPuz9bgH/ROQ6e0aAvEQMpRWMNVUYrKq efrqozcXHQU+eK7ceU5f3tX4PSPlMQ3pXGzt02n7sbsblFAnLZPCnJVfesaDBTav Cy9fnfU6dfwCGm7acwVYSAR+s6Wt1nOiKEn/ZNB1QUuvH+XbvdtZ4nAbEjeJzA45 ZBEdj/Dpj2Om3gTBbnmYVMpXeild0OPIFjupfWv0MZvAB2Dp8rOr6qJZXToBH+CZ XHN0ldR6djKVSLWVobY+rqII76pAhhMmgeEeHps8jUPShOtO0jGTqqMf/gk91gb/ cvXGbjqXSU/jBkNJExyCafkyWlocNiGSvYNvnaIT2Xts49WShD0DuScUgr8I+qQ= =1ZYE -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?507CB347.3040502>