Date: Sun, 30 Jun 2002 12:56:23 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Luigi Rizzo <luigi@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa clock.c src/sys/i386/include param.h src/sys/conf options.i386 Message-ID: <74337.1025434583@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 30 Jun 2002 03:31:34 PDT." <20020630033134.A80637@iguana.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020630033134.A80637@iguana.icir.org>, Luigi Rizzo writes: >But i want to emphasize that as usual this thread is about 20 lines >of conditionally compiled code which will never ever interfere with >anything else in the system. So, why check it in in the first place ? It is unused, undocumented and only you are ever going to use it and even you will have to modify the code to insert the calls to this code before you can use it. I have God knows my many pieces of code like that lying around, but since they are far to narrow of scope I don't commit them to the tree, no matter how convenient that would have been for me. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?74337.1025434583>