Date: Tue, 25 Nov 2014 10:36:51 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Ermal LuXXi <eri@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274709 - head/sys/netpfil/pf Message-ID: <86tx1nvcy4.fsf@nine.des.no> In-Reply-To: <201411191331.sAJDV9bH092190@svn.freebsd.org> (Ermal LuXXi's message of "Wed, 19 Nov 2014 13:31:09 %2B0000 (UTC)") References: <201411191331.sAJDV9bH092190@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ermal LuXXi <eri@FreeBSD.org> writes: > Log: > pf(4) needs to have a correct checksum during its processing. > Calculate checksums for the IPv6 path when needed before > delving into pf(4) code as required. >=20=20=20 > PR: 172648, 179392 > Reviewed by: glebius@ > Approved by: gnn@ > Obtained from: pfSense > MFC after: 1 week > Sponsored by: Netgate This is wrong, and causes a panic with some network adapters (vtnet, for one). It is closely related to 192013 and should not have been committed without consulting me first. Please revert, or just #if 0 out the entire block since the old code is even more wrong than your version. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86tx1nvcy4.fsf>