Date: Sat, 9 Mar 2024 20:55:12 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: jbo@insane.engineer Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0 Message-ID: <CAMHz58QGN2G3Cuv73WmrvSqToS3iHotBSUgkG4jR9BmLCc9sFQ@mail.gmail.com> In-Reply-To: <JYI0ZuMmj_UA5y1exhZLr-GyJbrSAynz2w8xGeMXWxC8-QyhP4fwMmyZP7zSvw6Gw1U9ey-6KI7FPrHVgYq9tX7n5cAHYF077JW7O2Bbq6U=@insane.engineer> References: <202402211520.41LFK8mS022399@gitrepo.freebsd.org> <JYI0ZuMmj_UA5y1exhZLr-GyJbrSAynz2w8xGeMXWxC8-QyhP4fwMmyZP7zSvw6Gw1U9ey-6KI7FPrHVgYq9tX7n5cAHYF077JW7O2Bbq6U=@insane.engineer>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000eba1dc061339d316 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2024 at 5:27=E2=80=AFAM <jbo@insane.engineer> wrote: > On Wednesday, February 21st, 2024 at 16:20, Po-Chuan Hsieh > <sunpoet@FreeBSD.org> wrote: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D450aafcba559f95c94c5f195d83b5= fe4fdc3748a > > > > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a > > Author: Po-Chuan Hsieh sunpoet@FreeBSD.org > > > > AuthorDate: 2024-02-21 14:29:27 +0000 > > Commit: Po-Chuan Hsieh sunpoet@FreeBSD.org > > > > CommitDate: 2024-02-21 15:06:47 +0000 > > > > textproc/tinyxml2: Update to 10.0.0 > > > > - Convert to meson > > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551 > > - Bump PORTREVISION for package change > > - Bump PORTREVISION of dependent ports for shlib change > > - Remove duplicate PORTREVISION from math/linbox > > > > Changes: https://github.com/leethomason/tinyxml2/releases > > https://github.com/leethomason/tinyxml2/commits/master > > --- > > Hi, > > This commit is in my opinion problematic. > The change in build system is causing consumers to no longer being able t= o > use CMake's find_package() and > the workaround that was put into place for some consumers is hacky at bes= t > and unacceptable at worst. > find_package() is doing a lot more under the hood than just setting an > LDFLAG. > > At least one consumer is still broken now (devel/gpds). > See PR #277227 > > Also, the commit message suggests that there was an update to 10.0.0 but > the port was already at 10.0.0. > > Best regards, > ~ jbo > Hello, If you find anything missing in the patch, I could add it. In my opinion, pkgconfig file is better than cmake script. At least it is build system independent. Speaking of devel/gpds, it just not on the radar when I checked the dependent ports. I prepared the 10.0.0 update last Dec and later I was unavailable until mid Feb. When I'm back, I checked again and there's no devel/gpds then. Then it took me days to build and fix the ports. ATM you added tinyxml2 dependence to devel/gpds. Anyway, I'll check the list of dependent ports again before I commit . Back to the fix, the answer is just 1 line after GPDS_DEPENDENCY_TINYXML2_FINDPACKAGE which you added to Makefile on Feb 18. I'll commit the fix later. from CMakeLists.txt: option(GPDS_DEPENDENCY_TINYXML2_FINDPACKAGE "Whether to use find_package() for the tinyxml2 dependency" OFF) option(GPDS_DEPENDENCY_TINYXML2_PKGCONFIG "Whether to use find_package(PkgConfig) for the tinyxml2 dependency" OFF) Regards, sunpoet --000000000000eba1dc061339d316 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Fri, Feb 23, 2024 at 5:27=E2=80=AFAM &= lt;jbo@insane.engineer> wrote:<br></div><div class=3D"gmail_quote"><bloc= kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:= 1px solid rgb(204,204,204);padding-left:1ex">On Wednesday, February 21st, 2= 024 at 16:20, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote: <br> > The branch main has been updated by sunpoet:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D450aafcba5= 59f95c94c5f195d83b5fe4fdc3748a" rel=3D"noreferrer" target=3D"_blank">https:= //cgit.FreeBSD.org/ports/commit/?id=3D450aafcba559f95c94c5f195d83b5fe4fdc37= 48a</a><br> > <br> > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a<br> > Author: Po-Chuan Hsieh sunpoet@FreeBSD.org<br> > <br> > AuthorDate: 2024-02-21 14:29:27 +0000<br> > Commit: Po-Chuan Hsieh sunpoet@FreeBSD.org<br> > <br> > CommitDate: 2024-02-21 15:06:47 +0000<br> > <br> > textproc/tinyxml2: Update to 10.0.0<br> > <br> > - Convert to meson<br> > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551<br> > - Bump PORTREVISION for package change<br> > - Bump PORTREVISION of dependent ports for shlib change<br> > - Remove duplicate PORTREVISION from math/linbox<br> > <br> > Changes: <a href=3D"https://github.com/leethomason/tinyxml2/releases" = rel=3D"noreferrer" target=3D"_blank">https://github.com/leethomason/tinyxml= 2/releases</a><br> > <a href=3D"https://github.com/leethomason/tinyxml2/commits/master" rel= =3D"noreferrer" target=3D"_blank">https://github.com/leethomason/tinyxml2/c= ommits/master</a><br> > ---<br> <br> Hi,<br> <br> This commit is in my opinion problematic.<br> The change in build system is causing consumers to no longer being able to = use CMake's find_package() and <br> the workaround that was put into place for some consumers is hacky at best = and unacceptable at worst.<br> find_package() is doing a lot more under the hood than just setting an LDFL= AG.<br> <br> At least one consumer is still broken now (devel/gpds).=C2=A0</blockquote><= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> <br> See PR #277227<br> <br> Also, the commit message suggests that there was an update to 10.0.0 but th= e port was already at 10.0.0.=C2=A0</blockquote><blockquote class=3D"gmail_= quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,= 204);padding-left:1ex"> <br> <br> Best regards,<br> ~ jbo<br></blockquote><div><br></div><div>Hello,</div><div><br></div><div>I= f you find anything missing in the patch, I could add it.</div><div>In my o= pinion, pkgconfig file=C2=A0is better than cmake script.</div><div>At least= it is build system independent.</div><div><br></div><div>Speaking of devel= /gpds, it just not on the radar when I checked the dependent ports.</div><d= iv>I prepared the 10.0.0 update last Dec and later I was unavailable until = mid Feb.</div><div>When I'm back, I checked again and there's no de= vel/gpds then.</div><div>Then it took me days to build and fix the ports.</= div><div>ATM you added tinyxml2 dependence to devel/gpds.</div><div>Anyway,= I'll check the list of dependent ports again before I commit .</div><d= iv><br></div><div>Back to the fix, the answer is just 1 line after=C2=A0GPD= S_DEPENDENCY_TINYXML2_FINDPACKAGE which you added to Makefile on Feb 18.</d= iv><div><div>I'll commit the fix later.</div><div></div></div><div><br>= </div><div>from CMakeLists.txt:</div><div>option(GPDS_DEPENDENCY_TINYXML2_F= INDPACKAGE "Whether to use find_package() for the tinyxml2 dependency&= quot; OFF)<br>option(GPDS_DEPENDENCY_TINYXML2_PKGCONFIG =C2=A0 "Whethe= r to use find_package(PkgConfig) for the tinyxml2 dependency" OFF)</di= v><div><br></div><div>Regards,</div><div>sunpoet</div></div></div> --000000000000eba1dc061339d316--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58QGN2G3Cuv73WmrvSqToS3iHotBSUgkG4jR9BmLCc9sFQ>