Date: Mon, 29 Jun 2020 17:21:13 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: =?UTF-8?Q?Stefan_E=c3=9fer?= <se@freebsd.org>, Ed Maste <emaste@freebsd.org>, John Baldwin <jhb@freebsd.org> Cc: Eric van Gyzen <eric@vangyzen.net>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362681 - in head: contrib/bc contrib/bc/gen contrib/bc/include contrib/bc/locales contrib/bc/manuals contrib/bc/src contrib/bc/src/bc contrib/bc/src/dc contrib/bc/src/history contrib/b... Message-ID: <0307b190-136c-59d1-bbde-976e6b181868@FreeBSD.org> In-Reply-To: <c4c42ea8-2c30-43d4-9546-25e89a936ff9@freebsd.org> References: <202006271202.05RC22oR085945@repo.freebsd.org> <2b7f0d0f-e243-9c9c-f1c0-e700e0bf6d48@FreeBSD.org> <577b1bd1-598a-d3f9-3c23-537b9747612a@vangyzen.net> <8670f956-1ed4-2b87-ee64-d04bc37d6810@freebsd.org> <ad53e8a5-b816-82bf-3bc7-41696c77d08a@FreeBSD.org> <CAPyFy2CMOQ7-k7m_X12PUrSa%2Bz51y%2BV9fMeLjCn9RJ3645m_CQ@mail.gmail.com> <c4c42ea8-2c30-43d4-9546-25e89a936ff9@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29/06/2020 16:11, Stefan Eßer wrote: > Am 29.06.20 um 20:09 schrieb Ed Maste: >> On Mon, 29 Jun 2020 at 11:27, John Baldwin <jhb@freebsd.org> wrote: >>> I suspect just doing the 'merge --record-only' is the simplest method >>> assuming Git handles it ok. I suspect since Git ignores mergeinfo this >>> is fine, but it would be good for Ed to confirm. You can always restore >>> the tests in the future in contrib/bc when you want to add them. >> I think a --record-only merge is the best approach; in any case we >> have a number of these in the tree already and Git will have to deal >> with them. > Thank you for this advice. > > There is a new version, which differs only in the man-pages. These > used to mention optional features (of which only NLS support is > actually optional in the version built on FreeBSD, all other are > always compiled in, and I had mentioned to the author that this > might irritate FreeBSD users). FWIW, since it was rewritten it would have been actually nice to have it in modern C++. > I have suggested to the author to add SPDX BSD-2-Clause tags, which > would change a large fraction of the currently committed files. We only use the SPDX tags for internal software. For stuff from contrib it is not necessary. > > Is it required to perform the --record-only merge, then? Since you are going to bring it through the vendor area you should keep the merge information yes. > Or would it be OK to import the new release into the vendor branch > and then svn copy that version completely (including the tests and > other files that I had omitted in the initial import) to contrib? > > I expect the svn copy without prior svn merge --record-only to > result in the same repository state after the conversion to Git, > but I do not really know ... It is likely git won't care. cheers, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0307b190-136c-59d1-bbde-976e6b181868>