Date: Thu, 15 Dec 2011 10:27:36 +0700 From: Max Khon <fjoe@samodelkin.net> To: Garrett Cooper <yanegomi@gmail.com> Cc: Alexander Best <arundel@freebsd.org>, Doug Barton <dougb@freebsd.org>, current@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: Remove debug echo Message-ID: <CADe0-4niyiLyTSofbnpovb4B-WpjnC9VEEM3_GeZFi-xVws=LQ@mail.gmail.com> In-Reply-To: <CAGH67wQGnSfnO0H4ok2=czm7uxdwY%2BBuDmtQdwuswjSBGt8szw@mail.gmail.com> References: <201111291607.26546.jhb@freebsd.org> <A6C0CFB3-A657-41AA-8A2E-172D95BD0F98@bsdimp.com> <20111201002515.GA50028@freebsd.org> <CAGH67wQFecLHFsANmWFSr6e%2B99P1QY9erNzoXFmJG40RntFazQ@mail.gmail.com> <20111201014349.GA61475@freebsd.org> <CAGH67wT18DLu%2BOhOOw-Pjyq9az0pWD39y4nuDY-nDyPOKbmd8Q@mail.gmail.com> <CAGH67wQGnSfnO0H4ok2=czm7uxdwY%2BBuDmtQdwuswjSBGt8szw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Garrett, On Thu, Dec 1, 2011 at 2:15 PM, Garrett Cooper <yanegomi@gmail.com> wrote: > I've attached a patch that makes make do what I would like it to do; > there are some other items that require cleanup to achieve the `argv0' > prefixing that's available in gmake, but this is good enough for a > meaningful traceback when things fail. Pastebin available here, just > in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv > > $ cat ~/Makefile > all: > cd $$HOME/foo; ${MAKE} $@ > $ cat ~/foo/Makefile > all: foo bar barf yadda > > foo bar yadda: > @true > > baz: > @false > > barf: baz > $ $PWD/make -j4 -f ~/Makefile all > cd $HOME/foo; /usr/src/usr.bin/make/make all > *** [baz] Error code 1 > 1 error > *** [all] Error code 2 > 1 error > $ > > If someone would please, PLEASE commit this.. I will give you beer, or > wine, or a copy of Skyrim, or a few months subscription to WoW, or > something else of value to you that we could negotiate :)... I'm quite > frankly tired of having to playing guessing games fishing through logs > trying to determine build errors on FreeBSD if and when they do occur > with pmake, and I'm sure that a number of developers and build/release > engineers out there are in the same boat as I am. > Can you explain why did you remove MESSAGE() invocations in your patch? Other than that the patch looks good to me. Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADe0-4niyiLyTSofbnpovb4B-WpjnC9VEEM3_GeZFi-xVws=LQ>