Date: Thu, 14 Apr 2016 13:41:48 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mark Millard <markmi@dsl-only.net>, FreeBSD Current <freebsd-current@freebsd.org>, FreeBSD PowerPC ML <freebsd-ppc@freebsd.org> Cc: Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: Fwd: 11.0: head/lib/libsysdecode/Makefile for . . ./libsoft/usr/include uses CPP when XCPP needed? [Makefile.libcompat issue] Message-ID: <5710008C.6030602@FreeBSD.org> In-Reply-To: <6311C740-362F-45AE-9044-B72E61FC04C9@dsl-only.net> References: <D8803949-18C1-4B17-981F-DAD5A2DEDCE8@dsl-only.net> <CANCZdfo3Gdf0QF64hfn_WJzxhPOwJk6yMB3qEkDi8tfEpRRveg@mail.gmail.com> <B222BAE7-FD73-4F54-8C31-E982B6FCA718@dsl-only.net> <3A6ED16B-F941-41FC-B844-50292894D5F4@dsl-only.net> <CANCZdfqX8d-DZ-Y%2B%2BDFjsP7L8M_xFTvFLknxgGLSf_zO-wSfdA@mail.gmail.com> <B6B88406-A0AE-4704-9343-F65CF8DDBC5D@dsl-only.net> <050EC0FA-21F9-4EAB-8771-B0F6E9DEE087@dsl-only.net> <9952A60C-C3F1-40C3-AEAE-96AF6CA6E829@dsl-only.net> <6311C740-362F-45AE-9044-B72E61FC04C9@dsl-only.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Ic6V6m0o7E4gROOmdKovmr3Sfj5xMutu8
Content-Type: multipart/mixed; boundary="lD5oGMAVA2qw3j06stsHHPupd9VmEQXhU"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Mark Millard <markmi@dsl-only.net>,
FreeBSD Current <freebsd-current@freebsd.org>,
FreeBSD PowerPC ML <freebsd-ppc@freebsd.org>
Cc: Bryan Drewery <bdrewery@FreeBSD.org>
Message-ID: <5710008C.6030602@FreeBSD.org>
Subject: Re: Fwd: 11.0: head/lib/libsysdecode/Makefile for . .
./libsoft/usr/include uses CPP when XCPP needed? [Makefile.libcompat issue]
References: <D8803949-18C1-4B17-981F-DAD5A2DEDCE8@dsl-only.net>
<CANCZdfo3Gdf0QF64hfn_WJzxhPOwJk6yMB3qEkDi8tfEpRRveg@mail.gmail.com>
<B222BAE7-FD73-4F54-8C31-E982B6FCA718@dsl-only.net>
<3A6ED16B-F941-41FC-B844-50292894D5F4@dsl-only.net>
<CANCZdfqX8d-DZ-Y++DFjsP7L8M_xFTvFLknxgGLSf_zO-wSfdA@mail.gmail.com>
<B6B88406-A0AE-4704-9343-F65CF8DDBC5D@dsl-only.net>
<050EC0FA-21F9-4EAB-8771-B0F6E9DEE087@dsl-only.net>
<9952A60C-C3F1-40C3-AEAE-96AF6CA6E829@dsl-only.net>
<6311C740-362F-45AE-9044-B72E61FC04C9@dsl-only.net>
In-Reply-To: <6311C740-362F-45AE-9044-B72E61FC04C9@dsl-only.net>
--lD5oGMAVA2qw3j06stsHHPupd9VmEQXhU
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 4/6/2016 1:14 PM, Mark Millard wrote:
> The below forwards an example of a possibly more general issue not nece=
ssarily limited to arm context of the example: in a cross compile context=
the host CPP is in use via Makefile.libcompat not involving "${XCPP}" an=
d so various macro checks for the target context fail to work.
>=20
> [The below and the material leading up to it was originally posted to f=
reebsd-arm.]
>=20
> =3D=3D=3D
> Mark Millard
> markmi at dsl-only.net
>=20
> On 2016-Apr-4, at 2:02 PM, Mark Millard <markmi at dsl-only.net> wrote:=
>=20
> As a fix for
>=20
>>> --- all_subdir_lib/libsysdecode ---
>>> In file included from <stdin>:17:
>>> In file included from /usr/obj/clang/arm.armv6/usr/src/libsoft/usr/in=
clude/dev/nvme/nvme.h:36:
>>> In file included from /usr/obj/clang/arm.armv6/usr/src/libsoft/usr/in=
clude/sys/param.h:135:
>>> In file included from /usr/obj/clang/arm.armv6/usr/src/libsoft/usr/in=
clude/machine/param.h:49:
>>> /usr/obj/clang/arm.armv6/usr/src/libsoft/usr/include/machine/acle-com=
pat.h:182:4: error: Unable to determine architecture version.
>>> # error Unable to determine architecture version.
>>> ^
>=20
> I tested building an amd64 -> arm cross-build based on
>=20
>> # svnlite diff Makefile.libcompat
>> Index: Makefile.libcompat
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- Makefile.libcompat (revision 297514)
>> +++ Makefile.libcompat (working copy)
>> @@ -90,6 +90,7 @@
>> DTRACE=3D"${LIB$COMPATDTRACE:U${DTRACE}}"
>> LIBCOMPATWMAKEFLAGS+=3D CC=3D"${XCC} ${LIBCOMPATCFLAGS}" \
>> CXX=3D"${XCXX} ${LIBCOMPATCFLAGS} ${LIBCOMPATCXXFLAGS}" \
>> + CPP=3D"${XCPP}" \
>> DESTDIR=3D${LIBCOMPATTMP} \
>> -DNO_CPU_CFLAGS \
>> MK_CTF=3Dno \
>=20
> and it completed without getting an "error:". So this addition to Makef=
ile.libcompat may be one option for a fix.
>=20
Yes this is needed. Please try this patch though:
https://people.freebsd.org/~bdrewery/patches/libcompat-xcpp.diff
--=20
Regards,
Bryan Drewery
--lD5oGMAVA2qw3j06stsHHPupd9VmEQXhU--
--Ic6V6m0o7E4gROOmdKovmr3Sfj5xMutu8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJXEACMAAoJEDXXcbtuRpfPiDMH/0hjfJsKoqBE4KPLWICRUyD+
3o1sq8DHR29mP0SVuE+TKI4yFxjVHiDaJgzHks6QbMhQ1+xL2w1xsV9WUSe4S1Av
X32+czAea1cerM+jk9zB8gTQsLoiv8GFBdtkofUzxf0qHX/2cGn6LGyQbElj5UsV
dZxPmRrOO0IuWJHUQ5z0fzuFlcowcqUSoOSdhvt2NKNmYtv4guHALcwrQDvbUXgw
tCjtsbeW1mQU+fFAMF1+IgPPC4T5ZrLizHsR5P4oh7ctYaWyEQ3sWCozDfyr6j6k
WNEgd5PSVYtwGApWLkoag5d68kdgGXgoHQ4bT02AT8O3FEgPlqXDVAZmPDXZpzs=
=yuGO
-----END PGP SIGNATURE-----
--Ic6V6m0o7E4gROOmdKovmr3Sfj5xMutu8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5710008C.6030602>