Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Mar 2014 01:30:33 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r263458 - head/sys/security/audit
Message-ID:  <201403210130.s2L1UXH9030560@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Fri Mar 21 01:30:33 2014
New Revision: 263458
URL: http://svnweb.freebsd.org/changeset/base/263458

Log:
  audit: plug FILEDESC_LOCK leak in audit_canon_path.
  
  MFC after:	3 days

Modified:
  head/sys/security/audit/audit_bsm_klib.c

Modified: head/sys/security/audit/audit_bsm_klib.c
==============================================================================
--- head/sys/security/audit/audit_bsm_klib.c	Fri Mar 21 00:56:56 2014	(r263457)
+++ head/sys/security/audit/audit_bsm_klib.c	Fri Mar 21 01:30:33 2014	(r263458)
@@ -497,6 +497,7 @@ audit_canon_path(struct thread *td, int 
 			/* XXX: fgetvp() that vhold()s vnode instead of vref()ing it would be better */
 			error = fgetvp(td, dirfd, NULL, &cvnp);
 			if (error) {
+				FILEDESC_SUNLOCK(fdp);
 				cpath[0] = '\0';
 				if (rvnp != NULL)
 					vdrop(rvnp);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403210130.s2L1UXH9030560>