Date: Fri, 29 Jun 2001 00:20:03 -0700 (PDT) From: Ruslan Ermilov <ru@FreeBSD.ORG> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/28449: sh(1) aborts on certain input Message-ID: <200106290720.f5T7K3l02897@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/28449; it has been noted by GNATS.
From: Ruslan Ermilov <ru@FreeBSD.ORG>
To: Tor.Egge@fast.no
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/28449: sh(1) aborts on certain input
Date: Fri, 29 Jun 2001 10:11:22 +0300
Nope, doesn't work. Your patch only hides the real bug, and
simply backs out changes Martin did in parser.c,v 1.27, etc.
> Index: parser.c
> ===================================================================
> RCS file: /home/ncvs/src/bin/sh/parser.c,v
> retrieving revision 1.36
> diff -u -r1.36 parser.c
> --- parser.c 2001/04/09 12:46:19 1.36
> +++ parser.c 2001/04/17 18:27:52
> @@ -977,7 +977,7 @@
> c != '`' && c != '$' &&
> (c != '"' || eofmark != NULL))
> USTPUTC('\\', out);
> - if (c >= 0 && SQSYNTAX[c] == CCTL)
> + if (SQSYNTAX[c] == CCTL)
> USTPUTC(CTLESC, out);
> else if (eofmark == NULL)
> USTPUTC(CTLQUOTEMARK, out);
With my test, `c' will be -126 here, and SQSYNTAX[-126] is obviously the
wrong thing.
Funny though, I've managed to make almost identical patch before I sent
a PR. :-)
Then realized that it's bogus, and the actual problem is that our sh(1)
is not 8-bit clean (apparently).
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106290720.f5T7K3l02897>