Date: Sat, 20 Apr 2024 22:39:06 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Vladimir Druzenko <vvd@freebsd.org> Cc: dev-commits-ports-main@freebsd.org, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org Subject: Re: git: e710744f6c83 - main - graphics/GraphicsMagick: Update to 1.3.43 Message-ID: <CAMHz58S8WVe6OrvK5Etty85Uus1pKCNbrKG1Z=uxYKpeLx2xsg@mail.gmail.com> In-Reply-To: <28fe5b36-8136-44b7-b08f-fe3b653d60d3@freebsd.org> References: <202404181253.43ICr61o069768@gitrepo.freebsd.org> <28fe5b36-8136-44b7-b08f-fe3b653d60d3@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000d254030616882c3b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2024 at 12:21=E2=80=AFAM Vladimir Druzenko <vvd@freebsd.org= > wrote: > 18.04.2024 15:53, Po-Chuan Hsieh =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3De710744f6c835f2b99cbfca56d523= d46109e63b0 > > > > commit e710744f6c835f2b99cbfca56d523d46109e63b0 > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2024-04-18 12:47:58 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2024-04-18 12:47:58 +0000 > > > > graphics/GraphicsMagick: Update to 1.3.43 > > > > Changes: http://www.graphicsmagick.org/NEWS.html > > --- > > graphics/GraphicsMagick/Makefile | 5 +- > > graphics/GraphicsMagick/distinfo | 6 +-- > > graphics/GraphicsMagick/files/patch-Makefile.in | 11 ---- > > graphics/GraphicsMagick/files/patch-coders_jxl.c | 63 > ---------------------- > > graphics/GraphicsMagick/files/patch-configure | 28 +++------- > > graphics/GraphicsMagick/files/patch-jpeg-turbo | 67 > ------------------------ > > graphics/GraphicsMagick/pkg-plist | 11 ++-- > > 7 files changed, 20 insertions(+), 171 deletions(-) > > > > diff --git a/graphics/GraphicsMagick/Makefile > b/graphics/GraphicsMagick/Makefile > > index be2ef664e5cf..98b9b182def1 100644 > > --- a/graphics/GraphicsMagick/Makefile > > +++ b/graphics/GraphicsMagick/Makefile > > @@ -1,6 +1,5 @@ > > PORTNAME=3D GraphicsMagick > > -PORTVERSION=3D 1.3.40 > > -PORTREVISION=3D 5 > > +PORTVERSION=3D 1.3.43 > > PORTEPOCH=3D 1 > > CATEGORIES=3D graphics > > MASTER_SITES=3D SF > > @@ -11,7 +10,7 @@ WWW=3D http://www.graphicsmagick.org/ > > > > LICENSE=3D MIT > > > > -USES=3D cpe libtool localbase pathfix pkgconfig tar:zst > > +USES=3D cpe libtool localbase pathfix pkgconfig tar:xz > > > > CONFIGURE_ARGS=3D --enable-shared --enable-static \ > > --with-windows-font-dir=3D${WINDOWS_FONT_DIR} \ > > Hello! > > Build fails with FPX option on: > > > libtool: link: cc -fopenmp -O2 -pipe -march=3Dnehalem > > -fstack-protector-strong -isystem /usr/local/include > > -fno-strict-aliasing -Wall -D_THREAD_SAFE -fstack-protector-strong > > -fstack-protector-strong -o utilities/.libs/gm utilities/gm.o > > -L/usr/local/lib magick/.libs/libGraphicsMagick.so -ljasper -lwmflite > > -ljxl -ljxl_threads -ltiff -ljbig -lsharpyuv -lwebp -lwebpmux > > -lfreetype -ljpeg -lpng16 -llcms2 -llcms2_fast_float -llcms2_threaded > > -lXext -lSM -lICE -lX11 -lxml2 -llzma -lbz2 -lz -lm -lpthread -lomp > > -fopenmp -Wl,-rpath -Wl,/usr/local/lib > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_InitSystem > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetToolkitMemoryLimit > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_ClearSystem > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_OpenImageByFilename > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_GetSummaryInformation > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_GetImageResultAspectRatio > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_CloseImage > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetResampleMethod > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_ReadImageRectangle > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_ReadImageTransformRectangle > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_CreateImageByFilename > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetJPEGCompression > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_SetSummaryInformation > > >>> referenced by magick/.libs/libGraphicsMagick.so > > > > ld: error: undefined reference due to --no-allow-shlib-undefined: > > FPX_WriteImageLine > > >>> referenced by magick/.libs/libGraphicsMagick.so > > cc: error: linker command failed with exit code 1 (use -v to see > > invocation) > > *** [utilities/gm] Error code 1 > > > Fixed with patch: > -USES=3D cpe libtool localbase pathfix pkgconfig tar:xz > +USES=3D cpe libtool localbase:ldflags pathfix pkgconfig tar:xz > +FPX_LDFLAGS=3D -lfpx > > Tested on 13.3-p1 amd64 in poudriere and on live system. > > If you agree I can commit self. > > -- > Best regards, > Vladimir Druzenko > Fixed in ports f57677209d3a6981cbb5e2bceba03c37ea2f65a8. Thanks. However, I'd like to remove it. I wonder if people really use fpx nowadays. --000000000000d254030616882c3b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Fri, Apr 19, 2024 at 12:21=E2=80=AFAM = Vladimir Druzenko <<a href=3D"mailto:vvd@freebsd.org">vvd@freebsd.org</a= >> wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail= _quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204= ,204);padding-left:1ex">18.04.2024 15:53, Po-Chuan Hsieh =D0=BF=D0=B8=D1=88= =D0=B5=D1=82:<br> > The branch main has been updated by sunpoet:<br> ><br> > URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3De710744f6c= 835f2b99cbfca56d523d46109e63b0" rel=3D"noreferrer" target=3D"_blank">https:= //cgit.FreeBSD.org/ports/commit/?id=3De710744f6c835f2b99cbfca56d523d46109e6= 3b0</a><br> ><br> > commit e710744f6c835f2b99cbfca56d523d46109e63b0<br> > Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2024-04-18 12:47:58 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2024-04-18 12:47:58 +0000<br> ><br> >=C2=A0 =C2=A0 =C2=A0 graphics/GraphicsMagick: Update to 1.3.43<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Changes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"htt= p://www.graphicsmagick.org/NEWS.html" rel=3D"noreferrer" target=3D"_blank">= http://www.graphicsmagick.org/NEWS.html</a><br> > ---<br> >=C2=A0 =C2=A0graphics/GraphicsMagick/Makefile=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 5 +-<br> >=C2=A0 =C2=A0graphics/GraphicsMagick/distinfo=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +--<br> >=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-Makefile.in=C2=A0 | 11= ----<br> >=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-coders_jxl.c | 63 ----= ------------------<br> >=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-configure=C2=A0 =C2=A0= | 28 +++-------<br> >=C2=A0 =C2=A0graphics/GraphicsMagick/files/patch-jpeg-turbo=C2=A0 =C2= =A0| 67 ------------------------<br> >=C2=A0 =C2=A0graphics/GraphicsMagick/pkg-plist=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 11 ++--<br> >=C2=A0 =C2=A07 files changed, 20 insertions(+), 171 deletions(-)<br> ><br> > diff --git a/graphics/GraphicsMagick/Makefile b/graphics/GraphicsMagic= k/Makefile<br> > index be2ef664e5cf..98b9b182def1 100644<br> > --- a/graphics/GraphicsMagick/Makefile<br> > +++ b/graphics/GraphicsMagick/Makefile<br> > @@ -1,6 +1,5 @@<br> >=C2=A0 =C2=A0PORTNAME=3D=C2=A0 =C2=A0GraphicsMagick<br> > -PORTVERSION=3D 1.3.40<br> > -PORTREVISION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 5<br> > +PORTVERSION=3D 1.3.43<br> >=C2=A0 =C2=A0PORTEPOCH=3D=C2=A0 1<br> >=C2=A0 =C2=A0CATEGORIES=3D graphics<br> >=C2=A0 =C2=A0MASTER_SITES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0SF<br> > @@ -11,7 +10,7 @@ WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 <a href=3D"http://www.graphicsmagick.org/" rel=3D"noreferrer" ta= rget=3D"_blank">http://www.graphicsmagick.org/</a><br> >=C2=A0 =C2=A0<br> >=C2=A0 =C2=A0LICENSE=3D=C2=A0 =C2=A0 MIT<br> >=C2=A0 =C2=A0<br> > -USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpe li= btool localbase pathfix pkgconfig tar:zst<br> > +USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpe li= btool localbase pathfix pkgconfig tar:xz<br> >=C2=A0 =C2=A0<br> >=C2=A0 =C2=A0CONFIGURE_ARGS=3D=C2=A0 =C2=A0 =C2=A0--enable-shared --ena= ble-static \<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-windows-f= ont-dir=3D${WINDOWS_FONT_DIR} \<br> <br> Hello!<br> <br> Build fails with FPX option on:<br> <br> > libtool: link: cc -fopenmp -O2 -pipe -march=3Dnehalem <br> > -fstack-protector-strong -isystem /usr/local/include <br> > -fno-strict-aliasing -Wall -D_THREAD_SAFE -fstack-protector-strong <br= > > -fstack-protector-strong -o utilities/.libs/gm utilities/gm.o=C2=A0 <b= r> > -L/usr/local/lib magick/.libs/libGraphicsMagick.so -ljasper -lwmflite = <br> > -ljxl -ljxl_threads -ltiff -ljbig -lsharpyuv -lwebp -lwebpmux <br> > -lfreetype -ljpeg -lpng16 -llcms2 -llcms2_fast_float -llcms2_threaded = <br> > -lXext -lSM -lICE -lX11 -lxml2 -llzma -lbz2 -lz -lm -lpthread -lomp <b= r> > -fopenmp -Wl,-rpath -Wl,/usr/local/lib<br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_InitSystem<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_SetToolkitMemoryLimit<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_ClearSystem<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_OpenImageByFilename<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_GetSummaryInformation<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_GetImageResultAspectRatio<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_CloseImage<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_SetResampleMethod<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_ReadImageRectangle<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_ReadImageTransformRectangle<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_CreateImageByFilename<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_SetJPEGCompression<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_SetSummaryInformation<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> ><br> > ld: error: undefined reference due to --no-allow-shlib-undefined: <br> > FPX_WriteImageLine<br> > >>> referenced by magick/.libs/libGraphicsMagick.so<br> > cc: error: linker command failed with exit code 1 (use -v to see <br> > invocation)<br> > *** [utilities/gm] Error code 1<br> <br> <br> Fixed with patch:<br> -USES=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cpe li= btool localbase pathfix pkgconfig tar:xz<br> +USES=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cpe li= btool localbase:ldflags pathfix pkgconfig tar:xz<br> +FPX_LDFLAGS=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 -lfpx<br> <br> Tested on 13.3-p1 amd64 in poudriere and on live system.<br> <br> If you agree I can commit self.<br> <br> -- <br> Best regards,<br> Vladimir Druzenko<br></blockquote><div><br></div><div>Fixed in ports f57677= 209d3a6981cbb5e2bceba03c37ea2f65a8. Thanks.</div><div>However, I'd like= to remove it. I wonder if people really use fpx nowadays.</div></div></div= > --000000000000d254030616882c3b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58S8WVe6OrvK5Etty85Uus1pKCNbrKG1Z=uxYKpeLx2xsg>