Date: Sun, 19 Feb 2017 13:12:15 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Allan Jude <allanjude@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313962 - in head: etc/mtree sys/boot/geli sys/geom/eli tests/sys/geom tests/sys/geom/eli tests/sys/geom/eli/pbkdf2 Message-ID: <AF58F6FF-1EF5-474B-A37C-924914B591B6@gmail.com> In-Reply-To: <b08b4252-7910-077b-0a6e-256aa06774ab@freebsd.org> References: <201702191930.v1JJUW3q051018@repo.freebsd.org> <FEC3571D-4183-4386-913D-6854636C102A@gmail.com> <b08b4252-7910-077b-0a6e-256aa06774ab@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Feb 19, 2017, at 13:07, Allan Jude <allanjude@freebsd.org> wrote:
…
> Sorry, I didn't think it actually built these tests unless testvect.h
> did not exist.
>
> These tests were written by jmg@, years ago, but by me.
>
> What do you think the best course of action is? Just disconnect this test?
To be safe, I’d probably just disconnect the dependency since the generated file (I assume) works by itself, e.g.
$ svn diff tests/sys/geom/eli/pbkdf2/Makefile
Index: tests/sys/geom/eli/pbkdf2/Makefile
===================================================================
--- tests/sys/geom/eli/pbkdf2/Makefile (revision 313971)
+++ tests/sys/geom/eli/pbkdf2/Makefile (working copy)
@@ -22,7 +22,7 @@
LIBADD.pbkdf2= crypto
-testvect.h: gentestvect.py
+testvect.h:
python gentestvect.py > $@
.include <bsd.test.mk>
We can work on removing the python dependency in the interim.
Thanks,
-Ngie
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJYqgowAAoJEPWDqSZpMIYV7lgQAK/tmzH1GPRKGFDBrRFNsuMc
dG4Q5MKFZ9xGjuq5c/nv3DDbHfMxtAEH3zPlkqP2jXmDXrylgh1VrNg03wFyZAw0
nrgZJ+7cfZtDOnVWXveB8T77xH/9u68VGcJDCgiK0bdAu5R8IUie7X3KK+sfNR1L
OHtVDi/97y1to6bvZ6x6gXe/6FzZ1uwKqsjGDFQA7nG+frFR0co5wt5ND8JVBkj+
sNPJqwdbp43AQ7ZA8dptrPr45qbj4jYSlbhCCoEPNrhQf/Djx0AskQATXHqMJKcU
JYf/is63XqpjfUO1nyjKCgSowd8UJn0BkSflmkCHl/IG2wolvTdP6gXy6Y+K4VNm
hYsUc6uN/3Vt/t7h6r8Bl3njda5wHedcW4q9T1aqMzNZmhHCeVFqyWCAdxRsphgu
1imUW5JAumqq2Yl3SRD3a96vCP/2bPQn9glv33gTZt3Zm7JJ8qkMFg5bx8DlB5/b
jcuV6HxGixfgzGLBx8rGHqUVYd/YfoH45lVMfTIGVvPxvZy7wdf7qxrhJk8jYdY0
Fm7jY6H9HccbVbDOH/Dnm0kiBAUT6yb391WQ07/8KtIzWf9dOB1BozeJ6BUjzyAs
MVR/e80chuNO77cs/uighutNScQNibnuRh+a9mWSuoiRN8LaOqfJ4sxcVSHpqMdT
RzSdJ7kqkin/37900lHS
=0DCX
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AF58F6FF-1EF5-474B-A37C-924914B591B6>