Date: Wed, 25 Oct 2000 21:54:22 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: Matthew Jacob <mjacob@feral.com>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Poul-Henning Kamp <phk@FreeBSD.org>, Greg Lehey <grog@lemis.com> Subject: Re: Making work for others (was: cvs commit: src/sys/sys mutex.h Message-ID: <Pine.BSF.4.21.0010252143220.25068-100000@besplex.bde.org> In-Reply-To: <XFMail.001024215218.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 24 Oct 2000, John Baldwin wrote: > On 25-Oct-00 Matthew Jacob wrote: > > > >> > Modified files: > >> > sys/sys mutex.h > >> > Log: > >> > Generate LOTS of warnings to remind the SMPng crew to fix the curproc > >> > UP/SMP issue. > >> > >> Is this necessary? Making work for other people isn't the way to go. > >> If you find the problem objectionable, do what others do and fix it. Especially since the correct fix is known (see my mail about it a week or two ago). I fixed it locally but didn't have time to commit it before bsdcon. Now all the half-baked fixes make it harder to catch up. > > Naw, I think he did the right thing. The warnings aren't that bad. The warnings should be errors so that whoever triggers them gets much mail. > I prefer the warnings to attempting to fix the problem as the fix would > have to be backed out later, whereas the warnings will go away on their > own once it is properly fixed with PCPU_GET(). PCPU_GET() is irrelevant to the proper fix. I think it is just at best an obfuscation (its current implementation is a pessimization for i386-UP). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0010252143220.25068-100000>