Date: Thu, 13 Feb 2014 18:38:05 -0500 From: Eitan Adler <lists@eitanadler.com> To: Robert Millan <rmh@freebsd.org> Cc: freebsd-x11@freebsd.org, Alex Kozlov <spam@rm-rf.kiev.ua> Subject: Re: [PATCH] ignore uhid devices in X devd backend Message-ID: <CAF6rxgnCKN-Sv%2BEP16ND6Pa_t0PXB2-ghx12L2YZO6%2B341XaEg@mail.gmail.com> In-Reply-To: <52FD5625.6010604@freebsd.org> References: <52EFAC5D.8010603@freebsd.org> <52FD5625.6010604@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 13, 2014 at 6:32 PM, Robert Millan <rmh@freebsd.org> wrote: > On 03/02/2014 14:49, Robert Millan wrote: >> >> This patch removes uhid from the hw_types[] list. According to the >> uhid driver description, this driver is only a fallback for devices >> not supported by any other driver. >> >> On my system, the USB keyboard shows up as an uhid device in addition >> to /dev/ukbd0, but the previous devd code misidentified it as a mouse. >> >> This just leads to trouble when X attempts to open() it and fails, >> for the reasons described in my earlier devd_no_kbd.diff patch. > > This might no longer apply with the code in: > > http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-devd > > which includes an open() test with fallback. > > (still I don't see the point of processing uhid devices, though) Even so, we still don't want to bother processing devices which can't possibly be correct. -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnCKN-Sv%2BEP16ND6Pa_t0PXB2-ghx12L2YZO6%2B341XaEg>