Date: Tue, 19 Jul 2011 04:31:09 +0200 From: Attilio Rao <attilio@freebsd.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224187 - in head: sys/amd64/amd64 sys/arm/arm sys/arm/sa11x0 sys/i386/i386 sys/ia64/ia64 sys/kern sys/mips/mips sys/powerpc/aim sys/powerpc/booke sys/sparc64/sparc64 sys/sys usr.bin/vm... Message-ID: <CAJ-FndCoqed8qEegmqr_ytRtNpkurZmC8bNHEgHVm8ciAU4cXQ@mail.gmail.com> In-Reply-To: <A51071FB-BB42-4F0F-81DB-C3EF13B6F39B@xcllnt.net> References: <201107181519.p6IFJfOK028280@svn.freebsd.org> <208D139E-CDC3-428D-8D5F-F772BFAF164C@xcllnt.net> <CAJ-FndDfQB-oJbc_R8b36LSjn=OzLRNZJ-P_%2BA1w=pkxhcUi_w@mail.gmail.com> <A51071FB-BB42-4F0F-81DB-C3EF13B6F39B@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/7/19 Marcel Moolenaar <marcel@xcllnt.net>: > > On Jul 18, 2011, at 5:59 PM, Attilio Rao wrote: > >> 2011/7/19 Marcel Moolenaar <marcel@xcllnt.net>: >>> >>> On Jul 18, 2011, at 8:19 AM, Attilio Rao wrote: >>> >>>> Author: attilio >>>> Date: Mon Jul 18 15:19:40 2011 >>>> New Revision: 224187 >>>> URL: http://svn.freebsd.org/changeset/base/224187 >>>> >>>> Log: >>>> =C2=A0- Remove the eintrcnt/eintrnames usage and introduce the concept= of >>>> =C2=A0 =C2=A0sintrcnt/sintrnames which are symbols containing the size= of the 2 >>>> =C2=A0 =C2=A0tables. >>>> =C2=A0- For amd64/i386 remove the storage of intr* stuff from assembly= files. >>>> =C2=A0 =C2=A0This area can be widely improved by applying the same to = other >>>> =C2=A0 =C2=A0architectures and likely finding an unified approach amon= g them and >>>> =C2=A0 =C2=A0move the whole code to be MI. More work in this area is e= xpected to >>>> =C2=A0 =C2=A0happen fairly soon. >>>> >>>> =C2=A0No MFC is previewed for this patch. >>> >>> You just broke ia64 and possibly other 64-bit architectures: >>> >>> ".word" declares a 16-bit integral on ia64 and the size symbols >>> are of type size_t (=3D64 bit). We'll be having misaligned loads >>> (=3D kernel panics) and/or reading garbage... >> >> I'm a bit surprised of this though. >> .hword was supposed to be the 16-bit integral, while .word was >> supposed to be the 32-bits one, if I read my "info as" on amd64. > > Well... all I can say is that assembly is the least transposable > language, besides of course machine code itself :-) > >> Anyway, what do you think about this patch? (I still need to test it): >> http://www.freebsd.org/~attilio/64bits-fixup.diff > > Looks good to me, though I don't know enough about mips to comment > on that. I'm not going to be anal about the use of ".quad" instead > of "data8" for ia64 -- let's get it fixed first (I think we have > ".byte" in locore.S anyway :-) We do. Anyway, I've updated the patch in order to use data8 in ia64 case (you are the maintainer, so you have the last word) even if I'm not sure there is a real need to discourage .quad. Thanks for pointing at this breakage, please review and approve in case. Attilio --=20 Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndCoqed8qEegmqr_ytRtNpkurZmC8bNHEgHVm8ciAU4cXQ>