Date: Mon, 20 Nov 2000 12:14:29 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Jake Burkholder <jburkhol@home.com> Cc: smp@FreeBSD.org Subject: Re: patch: allproc_lock Message-ID: <XFMail.001120121429.jhb@FreeBSD.org> In-Reply-To: <20001120080655.5BEA4BA7A@io.yi.org>
index | next in thread | previous in thread | raw e-mail
On 20-Nov-00 Jake Burkholder wrote: >> >> Attached is a patch that adds allproc_lock. This is a lockmgr >> lock which protectes the following: >> >> allproc >> zombproc >> pidhashtbl >> proc.p_list >> proc.p_hash >> nextpid >> >> Please review it. > > Sorry, too quick with the send...<blush> Well, I kind of don't like having allproc_lock/unlock functions. I would prefer explicit lockmgr() calls with on an allproc_lock variable. Also, we might consider having a very early SI_SUB_LOCKS_INIT that initializes lots of locks such as allproc_lock and the callout wheel mutex. Also, did you see my lock list document? Looks like I need to update it so it can handle lockmgr locks. :-P > Here's the patch: -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the messagehelp
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001120121429.jhb>