Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 08 Mar 2026 21:43:58 +0000
From:      Vladimir Druzenko <vvd@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Cc:        Jamie Landeg-Jones <jamie@catflap.org>
Subject:   git: 1c2c25efa837 - main - sysutils/symon: Fix build on 32 bit machines
Message-ID:  <69aded9e.3b789.77a38c85@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by vvd:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1c2c25efa837ff4659580ed7edd914ef02810849

commit 1c2c25efa837ff4659580ed7edd914ef02810849
Author:     Jamie Landeg-Jones <jamie@catflap.org>
AuthorDate: 2026-03-08 21:41:35 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2026-03-08 21:41:35 +0000

    sysutils/symon: Fix build on 32 bit machines
    
    symonnet.c:76:9: error: comparison of integers of different signs: 'ssize_t' (aka 'int') and 'u_int32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]"
    
    While here, also remove the unneccesary dependency on "groff".
    
    PR:     293667
---
 sysutils/symon/Makefile                     |  4 ++--
 sysutils/symon/files/patch-symon_symonnet.c | 20 ++++++++++++++++++++
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/sysutils/symon/Makefile b/sysutils/symon/Makefile
index 53cc318a3671..6e895cbe760d 100644
--- a/sysutils/symon/Makefile
+++ b/sysutils/symon/Makefile
@@ -1,6 +1,6 @@
 PORTNAME=	symon
 DISTVERSION=	2.90
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	sysutils
 MASTER_SITES=	https://wpd.home.xs4all.nl/symon/philes/
 
@@ -11,7 +11,7 @@ WWW=		https://wpd.home.xs4all.nl/symon/
 LICENSE=	BSD2CLAUSE
 LICENSE_FILE=	${WRKSRC}/LICENSE
 
-USES=		groff perl5 shebangfix
+USES=		perl5 shebangfix
 USE_PERL5=	build
 
 SHEBANG_FILES=	client/getsymonitem.pl
diff --git a/sysutils/symon/files/patch-symon_symonnet.c b/sysutils/symon/files/patch-symon_symonnet.c
new file mode 100644
index 000000000000..eeabcd6e59fa
--- /dev/null
+++ b/sysutils/symon/files/patch-symon_symonnet.c
@@ -0,0 +1,20 @@
+# The unpatched version made assumptions about types that don't hold true on 32 bit
+# machines. Express the same function in a more portable way.
+#
+# (The compile error was: symonnet.c:76:9: error: comparison of integers of different signs: 'ssize_t' (aka 'int') and 'u_int32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]"
+#
+--- symon/symonnet.c.orig	2025-01-03 13:36:33 UTC
++++ symon/symonnet.c
+@@ -70,9 +70,11 @@ send_packet(struct mux * mux)
+ void
+ send_packet(struct mux * mux)
+ {
+-    if (sendto(mux->symuxsocket, mux->packet.data,
++    ssize_t sent = sendto(mux->symuxsocket, mux->packet.data,
+                mux->packet.offset, 0, (struct sockaddr *) & mux->sockaddr,
+                SS_LEN(&mux->sockaddr))
++    ;
++    if (sent < 0 || (size_t)sent
+         != mux->packet.offset) {
+         mux->senderr++;
+     }


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69aded9e.3b789.77a38c85>