Date: Tue, 29 Sep 2009 18:54:47 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r197608 - head/sys/geom/part Message-ID: <20090929145447.GA82539@hades.panopticon> In-Reply-To: <200909290749.08764.jhb@freebsd.org> References: <200909282352.n8SNql1n069970@svn.freebsd.org> <200909290749.08764.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin (jhb@freebsd.org) wrote: > Why do you check for zeros at all? AFAIK, the only real check is for AA55 at > the end of the sector (and having an MBR or other Extended MBR partition > entry point at the sector in question). The '96' thing seems rather > arbitrary in the code, and I think the zero's check is overly restrictive. Seconded. I've seen a report of geom_part_ebr unable to detect partitions which were actually there. Will inquiry the reporter if this change solved the problem. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090929145447.GA82539>