Date: Tue, 11 Nov 2025 15:40:43 +0000 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: "David E. O'Brien" <obrien@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM Message-ID: <j76iielgc4t732o77lt47d6sog3gsu4lnbrqqpz6hg7blaebpa@v4xm2b5xd3f2> In-Reply-To: <202511110246.5AB2kdQc077401@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Nov 11, 2025 at 02:46:39AM +0000, David E. O'Brien wrote: > The branch main has been updated by obrien: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f1b9c1aafd8496c5bfdbc2be57bcfecfe58f12a8 > > commit f1b9c1aafd8496c5bfdbc2be57bcfecfe58f12a8 > Author: David E. O'Brien <obrien@FreeBSD.org> > AuthorDate: 2025-11-11 02:37:28 +0000 > Commit: David E. O'Brien <obrien@FreeBSD.org> > CommitDate: 2025-11-11 02:46:31 +0000 > > random: git'o in RANDOM_ENABLE_TPM > > Fixes: 3deb21f1a > --- > sys/dev/tpm/tpm20.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/dev/tpm/tpm20.h b/sys/dev/tpm/tpm20.h > index 7c2ccd30143a..b2cfcd4f25bd 100644 > --- a/sys/dev/tpm/tpm20.h > +++ b/sys/dev/tpm/tpm20.h > @@ -128,7 +128,7 @@ struct tpm_sc { > lwpid_t owner_tid; > > struct callout discard_buffer_callout; > -#ifdef TPM_HARVEST > +#if defined TPM_HARVEST || defined RANDOM_ENABLE_TPM All the examples that use `#if defined...` in the style(9) manual page show using parenthesis, though I'm not sure that equates to a style(9) rule. It seems awkward here not to use parenthesis when they are used (nearly?) everywhere else. Is this something that warrants clarification in style(9)? Thanks, -- Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmkTWPQACgkQ/y5nonf4 4fpLgBAAoPcgYjx4Mq3t65bZiBseX/6usXXUcV+jxuGl0RajyEiMfb7d4AA2od4H gKQgUUCXdr6xZLf0Lj5bCbLhp7U58rN+jbqKNg/EZr9EgZVIenVQG/9F3M0Xwr7w 9Ut+7apldvDF73WEY9YVDtr80EPSVBcIPUqnZG6nrzEa+T1AT1mLamumUvyzK63D pX3vXB5tulFZ7xC2uRGguKNzGtYwZHRnT7schGR+utLlOdEUVb+Q4BWIsH59k7yN iQaBZxyUm55vdGuxSM0jawAKtAPKjgbyvMPXuvm9+x19n7r4gM6gJF1MZfODaAy/ N5Qhf+v9qb3RpUzsnAhl4auJ4F2x68OhXZ8ErHCIsW/2hawnPY0orfvAgliKobuL Y/xnC/fPaYq/u2SnLRQLfh3Hws8igV8nCr6DNsPSpcTYk/foeMaIyP1hwQdaziPN 5bdGpzvOq0KozBC64wZa9agfTiN6GZKx/S9JAnnUdiJG+CC/K+ri8LnTNMnNqTEt v03TsdtJypumhsrBQkbKM8/T7KmLdJ9vyV6XcN8KuP94f3cjhRtmRMbgrMAMPn7t nxxlHLXk+MyjbzrX6BF0A++HHjvU3JQUy57wG6Jbfh26Bylt2hY+WFi5A717CmFC gZGVHiUagIwoYHjs33W4pYvzHvSIfwQFRp/wAdGezojEaKQSZWs= =Srti -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?j76iielgc4t732o77lt47d6sog3gsu4lnbrqqpz6hg7blaebpa>