Date: Mon, 26 Jan 2015 18:26:54 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk Message-ID: <F9F10CE5-3282-4BDF-AA65-9FF1F994412E@gmail.com> In-Reply-To: <86fvax91cy.fsf@nine.des.no> References: <201501260850.t0Q8oDna015719@svn.freebsd.org> <86fvax91cy.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Jan 26, 2015, at 4:23, Dag-Erling Smørgrav <des@des.no> wrote: > Garrett Cooper <ngie@FreeBSD.org> writes: >> Log: >> Honor MK_ACCT with etc/pam.d/atrun > > The correct idiom would be I disagree for a few reasons: 1. style.Makefile(9) makes no mention of having to use an idiom over the other. 2. The likelihood of typos creeping into Makefiles is greater with the _foo= idiom. 3. It creates unnecessary local variables — especially when appending is so easy to do. 4. It’s more difficult when backporting changes to do it with the variable method — especially if context around the line modified has changed a great deal. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUxvduAAoJEMZr5QU6S73enfIH/1pLmfrXzfKUjFRM+FhCqZf4 3gxJ/wemz8jTiQDfwo2Lhhq7PqK2UmtIEaVfF6X6nsF/9CcXbO7cu0ESKn5KC4U/ 7C1GVtYdUzp++Fy1L2YfexPgIOy8+cOYHyI/BXPEp2mKsOFyCtSBFnwQlYaAK5P3 +2Vqb2a5mnuwE9adRwGyJPrQjW7KQVNDC8PmkzyAC/YZHXtYnU3HpvLw0khQ0kgm LhMC423IfJ/74xEu7IJeq0ZGqPY0Ix3n3WcR/qwSFMk4KeI1WRxs9F5JQ/js6iaE W0yLn7cJXhKtBOARy5Mdn58ocx0F+kUp3bnquyVilwu2phmDs9WpR3Kn7hSXDkY= =SM3W -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F9F10CE5-3282-4BDF-AA65-9FF1F994412E>