Date: Tue, 14 Dec 2021 11:55:20 -0700 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 4dbc7835cdfc - main - mips: Turn off LLVM MIPS targets by default Message-ID: <CANCZdfrDxD5UL4on5Ccr=2%2Bc9zAbbDJaAD86mojzsuG0929z0g@mail.gmail.com> In-Reply-To: <CAPyFy2DxQJZ6zdSsT7r5S4=cky2durukqouznrib_yh6f2x6Tw@mail.gmail.com> References: <202112101831.1BAIVQbm048153@gitrepo.freebsd.org> <d398ab7e-f5e4-0301-2388-727250c73a30@FreeBSD.org> <CAPyFy2DxQJZ6zdSsT7r5S4=cky2durukqouznrib_yh6f2x6Tw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000c3091005d31fbb29 Content-Type: text/plain; charset="UTF-8" On Tue, Dec 14, 2021 at 11:43 AM Ed Maste <emaste@freebsd.org> wrote: > On Tue, 14 Dec 2021 at 13:27, John Baldwin <jhb@freebsd.org> wrote: > > > > This breaks NO_CLEAN=yes builds in I think a lot of object files. > > ... > > Perhaps we should be generating those header files in OBJDIR (and use a > move-if-changed > > scheme to avoid bumping the date if the contents haven't changed) so > that make can handle > > these changes? > > Seems reasonable if that change is straightforward, but we could also > just add a special case in tools/build/depend-cleanup.sh to handle > this. depend-cleanup can be fairly liberal, e.g. delete *.def. > Yea, we have no good way to prevent breakage for things like this short of moving the changing data into a file so dependencies can be tracked. I'm agnostic on the method. I'm also not sure I know of a good way to fix this short of doing a make clean if any of the mips .o files are present. In removing mips, I'm generally uninterested in making sure no clean works over that event because it is a one-shot. But am happy to work with others that are interested to mitigate the damage. Warner --000000000000c3091005d31fbb29--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrDxD5UL4on5Ccr=2%2Bc9zAbbDJaAD86mojzsuG0929z0g>