Date: Thu, 10 Nov 2022 17:02:26 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 294cb8bb3acc - stable/13 - ping: Remove a vestigial notdef Message-ID: <202211101702.2AAH2QbJ016222@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=294cb8bb3acc780ccd91f547b459d4e677894e6f commit 294cb8bb3acc780ccd91f547b459d4e677894e6f Author: Jose Luis Duran <jlduran@gmail.com> AuthorDate: 2022-11-01 08:01:36 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2022-11-10 17:01:17 +0000 ping: Remove a vestigial notdef It was once a function on 4.3BSD, pr_type() [1], used to convert an ICMP "type" field to a printable string. In 4.4BSD it was superseded by pr_icmph() [2]. NetBSD [3] and OpenBSD [4] have already removed it. [1]: https://minnie.tuhs.org/cgi-bin/utree.pl?file=4.3BSD/usr/src/etc/ping.c [2]: https://minnie.tuhs.org/cgi-bin/utree.pl?file=4.4BSD/usr/src/sbin/ping/ping.c [3]: https://github.com/NetBSD/src/commit/203dfd34867991fd002f747d74a96f26ae80d41c [4]: https://github.com/openbsd/src/commit/9bbbbbb75d24e3d166ddd0cb6cb4417b78561309 Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D37247 (cherry picked from commit 909e2e1b6c340af2581be30aaa38bc8d97c55532) --- sbin/ping/ping.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/sbin/ping/ping.c b/sbin/ping/ping.c index be535f72146a..be1ccfe29d23 100644 --- a/sbin/ping/ping.c +++ b/sbin/ping/ping.c @@ -1473,22 +1473,6 @@ finish(void) exit(2); } -#ifdef notdef -static char *ttab[] = { - "Echo Reply", /* ip + seq + udata */ - "Dest Unreachable", /* net, host, proto, port, frag, sr + IP */ - "Source Quench", /* IP */ - "Redirect", /* redirect type, gateway, + IP */ - "Echo", - "Time Exceeded", /* transit, frag reassem + IP */ - "Parameter Problem", /* pointer + IP */ - "Timestamp", /* id + seq + three timestamps */ - "Timestamp Reply", /* " */ - "Info Request", /* id + sq */ - "Info Reply" /* " */ -}; -#endif - /* * pr_icmph -- * Print a descriptive string about an ICMP header.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202211101702.2AAH2QbJ016222>