Date: Mon, 24 Jul 2023 13:06:54 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 80e4ac2964a1 - main - Work around VNET and DPCPU related panics on aarch64 Message-ID: <5A138CF6-8D9B-49B4-9684-BC0E76C17213@FreeBSD.org> In-Reply-To: <B059BE78-FD1A-4BA9-BA45-9FE0685C4A53@freebsd.org> References: <202307232238.36NMcBxN074108@gitrepo.freebsd.org> <B059BE78-FD1A-4BA9-BA45-9FE0685C4A53@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_6DF64140-DD36-4E5C-8F9E-425FB1820B4E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 24 Jul 2023, at 00:48, Jessica Clarke <jrtc27@freebsd.org> wrote: >=20 > On 23 Jul 2023, at 23:38, Dimitry Andric <dim@FreeBSD.org> wrote: >>=20 >> The branch main has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D80e4ac2964a11edef456a15b77e43aad= eaf273a2 >>=20 >> commit 80e4ac2964a11edef456a15b77e43aadeaf273a2 >> Author: Dimitry Andric <dim@FreeBSD.org> >> AuthorDate: 2023-07-23 13:48:36 +0000 >> Commit: Dimitry Andric <dim@FreeBSD.org> >> CommitDate: 2023-07-23 22:35:04 +0000 >>=20 >> Work around VNET and DPCPU related panics on aarch64 >>=20 >> lld >=3D 14 and recent GNU ld can relax adrp+add and adrp+ldr >> instructions, which breaks VNET and DPCPU when used in modules. >=20 > Thanks for committing the workaround. >=20 > This will need some kind of EN for 13.2 given LLVM 14 was merged in > time for that and arm64 is a Tier 1 architecture in 13. >=20 > There perhaps also needs to be some serious thought into our testing > and release procedures given we allowed a Tier 1 architecture to have > VNET and DPCU be totally broken in a point release for any kernel > module. Especially when the bug was known, open against -CURRENT and > triaged all before the MFC to stable/13; there needs to be better > tracking of toolchain release blockers. I agree, but how many users does this affect? I am only a sporadic user of aarch64 builds, but I never saw any panics, and apparently our CI builders also do not see these. So how often do these panics actually occur? Must you specifically use a VNET feature to encounter them? -Dimitry --Apple-Mail=_6DF64140-DD36-4E5C-8F9E-425FB1820B4E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZL5bTgAKCRCwXqMKLiCW o4aRAJ98Orz/n8qgp1Q7h91thV0dbqvv/gCguie00bHnIreg2P1kv0N2qCBewFI= =tsMm -----END PGP SIGNATURE----- --Apple-Mail=_6DF64140-DD36-4E5C-8F9E-425FB1820B4E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5A138CF6-8D9B-49B4-9684-BC0E76C17213>