Date: Tue, 14 Dec 2021 10:57:03 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4dbc7835cdfc - main - mips: Turn off LLVM MIPS targets by default Message-ID: <367d9216-53f7-044d-34b9-fae8460bd7bc@FreeBSD.org> In-Reply-To: <CAPyFy2DxQJZ6zdSsT7r5S4=cky2durukqouznrib_yh6f2x6Tw@mail.gmail.com> References: <202112101831.1BAIVQbm048153@gitrepo.freebsd.org> <d398ab7e-f5e4-0301-2388-727250c73a30@FreeBSD.org> <CAPyFy2DxQJZ6zdSsT7r5S4=cky2durukqouznrib_yh6f2x6Tw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/14/21 10:42 AM, Ed Maste wrote: > On Tue, 14 Dec 2021 at 13:27, John Baldwin <jhb@freebsd.org> wrote: >> >> This breaks NO_CLEAN=yes builds in I think a lot of object files. >> ... >> Perhaps we should be generating those header files in OBJDIR (and use a move-if-changed >> scheme to avoid bumping the date if the contents haven't changed) so that make can handle >> these changes? > > Seems reasonable if that change is straightforward, but we could also > just add a special case in tools/build/depend-cleanup.sh to handle > this. depend-cleanup can be fairly liberal, e.g. delete *.def. Yes, but the problem isn't deleting *.def. Those are static files whose content changes based on -D flags passed on the command line and you need to delete all the *.o files that include those .def files. Note that if you switch from WITHOUT_LLVM_TARGET_ALL to WITH_LLVM_TARGET_ALL or vice versa between builds you would also hit this issue. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?367d9216-53f7-044d-34b9-fae8460bd7bc>