Date: Fri, 03 Oct 2014 15:31:33 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 194117] New: libprocstat incorrectly extracts some ZFS information Message-ID: <bug-194117-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194117 Bug ID: 194117 Summary: libprocstat incorrectly extracts some ZFS information Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Many People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: avg@FreeBSD.org lib/libprocstat/zfs.c uses old ZFS znode_t layout that is not compatible with what is currently in kernel when it extracts vn_mode and vn_size. In particular, the code assumes that znode_t contains a pointer to a znode_phys_t object, which is not the case. I think that the required information can be extracted from z_size and z_mode fields in znode_t. While here, there is a comment in zfs_filestat() that talks about two byte offsets, while in reality the offsets are 2 * sizeof(pointer), e.g. 16 bytes on 64-bit systems. The code itself is correct. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194117-8>