Date: Thu, 11 Apr 2024 21:03:05 +0200
From: Mathieu Arnold <mat@freebsd.org>
To: Gleb Popov <arrowd@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: 665b0219e541 - main - Mk/Uses: Fix feature checks after my previous {WITH,WITHOUT}_*_PORTS change
Message-ID: <pvroeqehet64q4cepgfzleu5uh4z7l4mv5jjvwc4shkuppbz3l@z3yuc7iubtec>
In-Reply-To: <202404111754.43BHsjgV004072@gitrepo.freebsd.org>
References: <202404111754.43BHsjgV004072@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6wvezb7w6j36tdnm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, I'm picking on one hunk but they all look similar. On Thu, Apr 11, 2024 at 05:54:45PM +0000, Gleb Popov wrote: > -. if !defined(WITH_DEBUG) > +. if !defined(_WITH_DEBUG) I don't really understand, is WITH_DEBUG gone ? Because that cannot be. There are a gazillion of ports that do stuff when WITH_DEBUG. If I set WITH_DEBUG_PORTS+=3Ddns/bind918, and then I build dns/bind918, I assume that WITH_DEBUG will be set in that port. $ make -C dns/bind918 -V USE_PERL5 $ make -C dns/bind918 -V USE_PERL5 WITH_DEBUG=3Dy build $ make -C dns/bind918 -V USE_PERL5 WITH_DEBUG_PORTS=3Ddns/bind918 So, you broke WITH_DEBUG_PORTS :( Can you please immediately revert this commit (665b0219e541) and the one that broke it to begin with ? --=20 Mathieu Arnold --6wvezb7w6j36tdnm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmYYM+hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb7bBgv+LLKfIeTcQKGI0W6wNL87tzu+gmTODTN0yGHLyItuxmFJssbg75mN+ge9 9WvRahngj/PUNkBFerpHiBTCEnLOVCvMcxnKgRntMlDFJqzotd1SeVZ6KsO45v6N h4La6FQJRJ5tNsrRj5bcpGsZ9KFMON0XOCCwvXwKUsoz72Il189hlAIAVNi7TcJP GdrnW7IKmu7Xzh4mElYORV+1knVHpZhtCfXGo2uUG6NOr6nP40BWwdJyNSeUDIt7 JU10chHm0M7ayQCbVHE5kfUa+fwEn+uZl0gk9KwCj3UFnbers1zzMga0J356kLN5 2Xs95AVlQDCxdoyY4dW8/PXMZtWL8UZ6TJPMZV9T5djAcRmgv8OdhRGBGyeSH642 qxTGdnC+mNomSf/fTBi/adAFWqxwNX7T88Srm/1RAZcy7gUMxo/zMnn9oLDTOs0N /xRcnHg1gNddj4irD2Fp7RT6worfJlD459DQRbPQbMBaf/wrJTqytywBxS5whRBg dgiVDMro =QQ3U -----END PGP SIGNATURE----- --6wvezb7w6j36tdnm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?pvroeqehet64q4cepgfzleu5uh4z7l4mv5jjvwc4shkuppbz3l>