Date: Sun, 18 Feb 2007 11:39:27 -0500 From: "Siavosh Benabbas" <sbenabas@gmail.com> To: freebsd-multimedia@freebsd.org Subject: ports/104427: ffmpeg-devel port's Makefile can corrupt makefile's Message-ID: <32d8477c0702180839x3654f8e6i580dbc06bdeadf1c@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
------=_Part_12741_7217158.1171816767955 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello All, I filed this http://www.freebsd.org/cgi/query-pr.cgi?pr=104427 PR some time ago but it was never fixed/closed. I don't know if this is the right list but I will post it anyway. Basically the ffmpeg-devel port's Makefile has a ${REINPLACE_CMD} line ${REINPLACE_CMD} -E \ -e 's@^(CFLAGS.+)$$@\1 ${FFMPEG_CFLAGS}@' \ -e 's@^(FFLIBS|LDFLAGS)(.+)$$@\1\2 ${FFMPEG_LDFLAGS}@' This would corrupt the Makefile if a CFLAGS assignment is split over multiple lines using \ at the end of the lines. These long assignments are present in new ffmpeg sources but the port has not been updated to the last version of ffmpeg for a long time. I have also posted a patch which brings all such lines to the pattern space and fixes the problem, it is attached. Thanks, Siavosh ------=_Part_12741_7217158.1171816767955 Content-Type: text/x-patch; name=patch-1.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_eybph81u Content-Disposition: attachment; filename="patch-1.diff" LS0tIE1ha2VmaWxlLm9yaWcJU2F0IE9jdCAxNCAxNTozODozOSAyMDA2CisrKyBNYWtlZmlsZQlT YXQgT2N0IDE0IDIyOjQ2OjA1IDIwMDYKQEAgLTQ3NCw2ICs0NzQsOCBAQAogCUAke0ZJTkR9ICR7 V1JLRElSfSAtdHlwZSBmIC1uYW1lICJNYWtlZmlsZSIgLXByaW50MCB8IFwKIAkJJHtYQVJHU30g LTAgLW4gNSAteCBcCiAJCQkke1JFSU5QTEFDRV9DTUR9IC1FIFwKKwkJCS1lICc6YWdhaW4nIC1l ICcvLipcXCQkL04nIC1lICdzLyguKilcXCQkL1wxXFwvZycgXAorCQkJLWUgJ3QgYWdhaW4nIFwK IAkJCS1lICdzQF4oQ0ZMQUdTLispJCRAXDEgJHtGRk1QRUdfQ0ZMQUdTfUAnIFwKIAkJCS1lICdz QF4oRkZMSUJTfExERkxBR1MpKC4rKSQkQFwxXDIgJHtGRk1QRUdfTERGTEFHU31AJwogIyBmaXgg eDI2NCBtYXRoLCB1c2UgY29ycmVjdCBsb2cgYmFzZSAyIGZyb20gbWF0aCgzKQoK ------=_Part_12741_7217158.1171816767955--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32d8477c0702180839x3654f8e6i580dbc06bdeadf1c>