Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 14 Apr 2020 20:53:13 +0000 (UTC)
From:      Brooks Davis <brooks@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r359938 - in head/sys: compat/freebsd32 kern
Message-ID:  <202004142053.03EKrDYl001307@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: brooks
Date: Tue Apr 14 20:53:12 2020
New Revision: 359938
URL: https://svnweb.freebsd.org/changeset/base/359938

Log:
  Remove bogus use of useracc() in (clock_)nanosleep.
  
  There's no point in pre-checking that we can access the user's rmtp
  pointer before we do it in copyout().
  
  While here, improve style(9) compliance.
  
  Reviewed by:	imp
  MFC after:	1 week
  Sponsored by:	DARPA
  Differential Revision:	https://reviews.freebsd.org/D24409

Modified:
  head/sys/compat/freebsd32/freebsd32_misc.c
  head/sys/kern/kern_time.c

Modified: head/sys/compat/freebsd32/freebsd32_misc.c
==============================================================================
--- head/sys/compat/freebsd32/freebsd32_misc.c	Tue Apr 14 20:30:48 2020	(r359937)
+++ head/sys/compat/freebsd32/freebsd32_misc.c	Tue Apr 14 20:53:12 2020	(r359938)
@@ -2651,7 +2651,7 @@ freebsd32_user_clock_nanosleep(struct thread *td, cloc
 {
 	struct timespec32 rmt32, rqt32;
 	struct timespec rmt, rqt;
-	int error;
+	int error, error2;
 
 	error = copyin(ua_rqtp, &rqt32, sizeof(rqt32));
 	if (error)
@@ -2660,18 +2660,13 @@ freebsd32_user_clock_nanosleep(struct thread *td, cloc
 	CP(rqt32, rqt, tv_sec);
 	CP(rqt32, rqt, tv_nsec);
 
-	if (ua_rmtp != NULL && (flags & TIMER_ABSTIME) == 0 &&
-	    !useracc(ua_rmtp, sizeof(rmt32), VM_PROT_WRITE))
-		return (EFAULT);
 	error = kern_clock_nanosleep(td, clock_id, flags, &rqt, &rmt);
 	if (error == EINTR && ua_rmtp != NULL && (flags & TIMER_ABSTIME) == 0) {
-		int error2;
-
 		CP(rmt, rmt32, tv_sec);
 		CP(rmt, rmt32, tv_nsec);
 
 		error2 = copyout(&rmt32, ua_rmtp, sizeof(rmt32));
-		if (error2)
+		if (error2 != 0)
 			error = error2;
 	}
 	return (error);

Modified: head/sys/kern/kern_time.c
==============================================================================
--- head/sys/kern/kern_time.c	Tue Apr 14 20:30:48 2020	(r359937)
+++ head/sys/kern/kern_time.c	Tue Apr 14 20:53:12 2020	(r359938)
@@ -625,20 +625,15 @@ user_clock_nanosleep(struct thread *td, clockid_t cloc
     const struct timespec *ua_rqtp, struct timespec *ua_rmtp)
 {
 	struct timespec rmt, rqt;
-	int error;
+	int error, error2;
 
 	error = copyin(ua_rqtp, &rqt, sizeof(rqt));
 	if (error)
 		return (error);
-	if (ua_rmtp != NULL && (flags & TIMER_ABSTIME) == 0 &&
-	    !useracc(ua_rmtp, sizeof(rmt), VM_PROT_WRITE))
-		return (EFAULT);
 	error = kern_clock_nanosleep(td, clock_id, flags, &rqt, &rmt);
 	if (error == EINTR && ua_rmtp != NULL && (flags & TIMER_ABSTIME) == 0) {
-		int error2;
-
 		error2 = copyout(&rmt, ua_rmtp, sizeof(rmt));
-		if (error2)
+		if (error2 != 0)
 			error = error2;
 	}
 	return (error);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004142053.03EKrDYl001307>